feat(server): add wildcard CORS origin support#28743
Open
ducng99 wants to merge 1 commit into
Open
Conversation
Author
|
Another way is setting empty array for I'm not sure which way is preferred. diff --git a/packages/opencode/src/server/routes/instance/httpapi/server.ts b/packages/opencode/src/server/routes/instance/httpapi/server.ts
index 6ccc995..2e027ed 100644
--- a/packages/opencode/src/server/routes/instance/httpapi/server.ts
+++ b/packages/opencode/src/server/routes/instance/httpapi/server.ts
@@ -94,7 +94,7 @@ export const context = Context.makeUnsafe<unknown>(new Map())
const cors = (corsOptions?: CorsOptions) =>
HttpRouter.middleware(
HttpMiddleware.cors({
- allowedOrigins: (origin) => isAllowedCorsOrigin(origin, corsOptions),
+ allowedOrigins: corsOptions?.cors?.includes("*") ? [] : (origin) => isAllowedCorsOrigin(origin, corsOptions),
maxAge: 86_400,
}),
{ global: true }, |
This was referenced May 22, 2026
e367998 to
e7e0fcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
None
Type of change
What does this PR do?
Adds wildcard (
*) origin support toisAllowedCorsOrigininsrc/server/cors.ts. When the server is configured withcors: ["*"], any incomingOriginheader is now accepted and reflected back inAccess-Control-Allow-Origin.How did you verify your code works?
I ran an opencode server with and without cors, then fetch from my website (has a different origin) to verify the request went through with
Access-Control-Allow-Originset.Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.