fix(opencode): handle AbortError in session processor to prevent side…#29251
Open
patihomirov wants to merge 1 commit into
Open
fix(opencode): handle AbortError in session processor to prevent side…#29251patihomirov wants to merge 1 commit into
patihomirov wants to merge 1 commit into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #26667
Type of change
What does this PR do?
When an LLM stream is interrupted (network timeout, API disconnection), the unhandled
AbortErrorpropagates up the Effect.js fiber stack and crashes the entire sidecar process.In
packages/opencode/src/session/processor.ts,Effect.catchCauseIfonly catches non-interrupt causes. WhenAbortErroroccurs during stream interruption, it bypassesEffect.catch(halt)and crashes the sidecar instead of being handled gracefully.The fix adds
Effect.catchCausebeforeEffect.catch(halt)to properly catch and handleAbortErrorvia the existinghalt()handler. This ensures the error is logged, stored inassistantMessage.error, and the session transitions to idle state - instead of crashing the sidecar.How did you verify your code works?
Built a patched desktop version and ran a long LLM task that triggered a stream interruption. Previously this would crash the sidecar with
AbortError: Abortedlogged in journalctl. With the patch, the sidecar stays alive and the error is handled gracefully (logged viahalt(), session transitions to idle).Screenshots / recordings
N/A - not a UI change.
Checklist