Skip to content

fix(config): fallback when user info unavailable#29332

Merged
nexxeln merged 1 commit into
devfrom
fix/config-username-fallback
May 26, 2026
Merged

fix(config): fallback when user info unavailable#29332
nexxeln merged 1 commit into
devfrom
fix/config-username-fallback

Conversation

@nexxeln
Copy link
Copy Markdown
Member

@nexxeln nexxeln commented May 26, 2026

Closes #29292

Summary

  • fall back to "user" when os.userInfo() is unavailable during config startup
  • apply the same inline fallback to macOS managed preference lookup
  • add a regression test for missing system user info

Validation

  • bun test test/config/config.test.ts -t "falls back to generic username"
  • bun turbo typecheck via pre-push

@nexxeln nexxeln marked this pull request as ready for review May 26, 2026 07:00
@nexxeln nexxeln merged commit b5632ea into dev May 26, 2026
12 of 14 checks passed
@nexxeln nexxeln deleted the fix/config-username-fallback branch May 26, 2026 07:12
@YOMXXX
Copy link
Copy Markdown

YOMXXX commented May 26, 2026

Thanks for landing the smaller version.

One note: #29296 identified the same os.userInfo() fallback issue and also covered the managed preferences call site, which this PR adopted. Could you add a short note linking #29296 as prior work / inspiration? That would make the contribution trail clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config initialization crashes when os.userInfo() fails in containers

2 participants