test(app): restore timeline e2e server health mock#29336
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores e2e timeline regression specs by extending the shared Playwright mock server to satisfy the new /global/health startup probe and to support per-test SSE event injection, then refactors the two timeline regression specs to use the shared mock instead of duplicate route tables.
Changes:
- Add
/global/healthresponse and optionaleventsfactory to the shared mock server, threading queued events throughsse(). - Replace inline route tables in two regression specs with
mockOpenCodeServercalls.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/app/e2e/utils/mock-server.ts | Adds healthy /global/health response and optional events factory for SSE payloads. |
| packages/app/e2e/regression/session-timeline-context-resize.spec.ts | Removes duplicated route table and uses the shared mock helper. |
| packages/app/e2e/regression/session-timeline-collapse-state.spec.ts | Removes duplicated route table and forwards queued events via the shared mock. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cause
After global server health moved into app startup state, these timeline tests still returned an empty object for
/global/health. The app correctly treated the mocked server as unhealthy and stayed on the reconnect screen before reaching any timeline assertion.Validation
bunx playwright test e2e/smoke/session-timeline.spec.ts e2e/regression/session-timeline-collapse-state.spec.ts e2e/regression/session-timeline-context-resize.spec.ts— 4 passedbun typecheckinpackages/appbun turbo typecheck— 18 successful