Skip to content

fix(opencode): scope rtk permission patterns#29338

Open
YOMXXX wants to merge 1 commit into
anomalyco:devfrom
YOMXXX:fix/rtk-permission-arity
Open

fix(opencode): scope rtk permission patterns#29338
YOMXXX wants to merge 1 commit into
anomalyco:devfrom
YOMXXX:fix/rtk-permission-arity

Conversation

@YOMXXX
Copy link
Copy Markdown

@YOMXXX YOMXXX commented May 26, 2026

Issue for this PR

Closes #29311

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

The bash permission arity dictionary did not know about rtk, so an always-allow decision for commands such as rtk env PATH or rtk git clone ... collapsed to rtk *. That pattern is broader than the command the user approved.

This PR adds rtk arity entries for the wrapper's top-level and nested subcommands, including git, docker compose, telemetry, hook, package manager, and language/tool wrappers. The added regression test confirms rtk env *, rtk git clone *, rtk docker compose logs *, and rtk telemetry status * style prefixes are produced.

How did you verify your code works?

  • cd packages/opencode && PATH="$HOME/.bun/bin:$PATH" bun test test/permission/arity.test.ts
  • cd packages/opencode && PATH="$HOME/.bun/bin:$PATH" bun typecheck
  • git diff --check
  • PATH="$HOME/.bun/bin:$PATH" .husky/pre-push

Screenshots / recordings

Not applicable; permission pattern generation only.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: add rtk to bash arity dictionary

1 participant