Skip to content

fix(tui): prevent spinner garbage in non-TTY environments #29601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imtiazNDMA wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(tui): prevent spinner garbage in non-TTY environments #29601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/opencode/src/cli/cmd/plug.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,17 @@ type Spin = {
stop: (msg: string, code?: number) => void
}

function ttySpinner(): Spin {
if (process.stdout.isTTY) return spinner()
return {
start: (msg: string) => console.log(msg),
stop: (msg: string, code?: number) => {
if (code) console.error(msg)
else console.log(msg)
},
}
}

export type PlugDeps = {
spinner: () => Spin
log: {
Expand Down Expand Up @@ -45,7 +56,7 @@ export type PlugCtx = {
}

const defaultPlugDeps: PlugDeps = {
spinner: () => spinner(),
spinner: () => ttySpinner(),
log: {
error: (msg) => log.error(msg),
info: (msg) => log.info(msg),
Expand Down
Loading