Skip to content

fix(openai): support websocket custom base URLs#29636

Merged
rekram1-node merged 1 commit into
anomalyco:devfrom
Tarquinen:fix/openai-ws-base-url
May 27, 2026
Merged

fix(openai): support websocket custom base URLs#29636
rekram1-node merged 1 commit into
anomalyco:devfrom
Tarquinen:fix/openai-ws-base-url

Conversation

@Tarquinen
Copy link
Copy Markdown
Contributor

Issue for this PR

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Allows codex oauth websocket to handle custom openai baseURL that use /responses path

How did you verify your code works?

added logs to see I was connected through websockets for both default openai and through a custom baseURL, see below

Screenshots / recordings

image

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added needs:issue needs:compliance This means the issue will auto-close after 2 hours. labels May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions
Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • No issue referenced. Please add Closes #<number> linking to the relevant issue.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate Found

PR #29394: feat(opencode): add experimental OpenAI Responses WebSocket
#29394

Why it's related:

PR #29394 adds the experimental OpenAI Responses WebSocket feature, while PR #29636 (current) fixes support for custom OpenAI base URLs with that WebSocket implementation. These PRs are closely related—the current fix likely addresses an issue discovered in PR #29394's feature. You may want to check if #29394 is already merged and whether this fix should be incorporated there or if they should be reviewed together.

@rekram1-node rekram1-node merged commit ec26d78 into anomalyco:dev May 27, 2026
4 checks passed
@Tarquinen Tarquinen deleted the fix/openai-ws-base-url branch May 28, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor needs:compliance This means the issue will auto-close after 2 hours. needs:issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants