feat(tui): integrate ServerAuth headers into transport configuration for external served TUI thread#29876
Open
OpeOginni wants to merge 1 commit into
Open
feat(tui): integrate ServerAuth headers into transport configuration for external served TUI thread#29876OpeOginni wants to merge 1 commit into
OpeOginni wants to merge 1 commit into
Conversation
…for external served TUI thread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29847
Type of change
What does this PR do?
Only enter external mode from explicit CLI flags: removed the config-derived conditions. Now the TUI stays in internal worker mode unless the user explicitly passes --port, --hostname, or --mdns.
Pass auth headers when external mode is used: when the TUI does enter external mode (explicitly requested), it now generates auth headers from ServerAuth.headers() and passes them through to the SDK client and validateSession, just like attach.ts already does.
How did you verify your code works?
Typecheck passes, and tested out running the tui with a password and passing the
--hostnameand--mdnsflags to create an external server instance with the TUI.Screenshots / recordings
Checklist