fix(edit): preserve leading whitespace in TrimmedBoundaryReplacer#29995
Open
levgiorg wants to merge 1 commit into
Open
fix(edit): preserve leading whitespace in TrimmedBoundaryReplacer#29995levgiorg wants to merge 1 commit into
levgiorg wants to merge 1 commit into
Conversation
The TrimmedBoundaryReplacer yielded trimmedFind (find.trim()) without leading whitespace context. content.indexOf(trimmedFind) skipped past indentation, but content.substring(0, index) preserved the original whitespace, causing doubled indentation on replacement. Remove the direct trimmedFind yield — only yield blocks matched from actual content with correct indentation. Fixes anomalyco#29573
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29573
Type of change
What does this PR do?
Fixes
TrimmedBoundaryReplacerwhich yielded trimmed search text (find.trim()) without indentation context. Thecontent.indexOf(trimmedFind)call found the match AFTER leading whitespace, butcontent.substring(0, index)preserved those leading spaces. The concatenation then produced doubled indentation. The fix removes the directtrimmedFindyield — only blocks matched from actual file content (with correct indentation) are yielded.How did you verify your code works?
Screenshots / recordings
Not applicable — no UI change.
Checklist