fix(project): update worktree when original directory no longer exists#30007
Open
lgcenen wants to merge 1 commit into
Open
fix(project): update worktree when original directory no longer exists#30007lgcenen wants to merge 1 commit into
lgcenen wants to merge 1 commit into
Conversation
When a project is moved to a new directory and re-opened, the old worktree path is kept in the database, causing the GUI to keep using the stale path. This adds an existence check — if the stored worktree no longer exists on disk, the worktree is updated to the current directory and removed from sandboxes.
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30005
Type of change
What does this PR do?
When a project is moved from its original location to a new path, closing the old workspace in the GUI and re-adding it at the new path does not update the stored worktree. The database keeps the old (non-existent) path, and the GUI's sandbox auto-routing closes the newly added project and re-opens the old one.
This adds an existence check in
fromDirectory(): after filtering sandboxes, if the storedworktreeno longer exists on disk, update it to the current directory and remove from sandboxes.How did you verify your code works?
Screenshots / recordings
Not a UI change.
Checklist