fix(provider): reject unsupported image MIME attachments#30023
Open
he-yufeng wants to merge 1 commit into
Open
fix(provider): reject unsupported image MIME attachments#30023he-yufeng wants to merge 1 commit into
he-yufeng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30016
Type of change
What does this PR do?
Persisted
.icoattachments can be replayed asimage/vnd.microsoft.iconfile parts. Before this change, the provider transform treated everyimage/*MIME type as image modality input, so any multimodal-capable model would receive the unsupported ICO payload instead of a recoverable user-visible error.This keeps the existing supported image set to JPEG, PNG, GIF, and WebP when building model messages. Other image MIME types are converted to an error text part, so old sessions containing ICO files can continue and the model can tell the user the attachment is unsupported.
How did you verify your code works?
bun --cwd packages/opencode test test/provider/transform.test.tsbun run --cwd packages/opencode typecheckbunx prettier --check packages/opencode/src/provider/transform.ts packages/opencode/test/provider/transform.test.tsbunx oxlint packages/opencode/src/provider/transform.ts packages/opencode/test/provider/transform.test.ts(exit 0; existing warnings remain in this file)git diff --checkScreenshots / recordings
No screenshot. This changes model-message transformation for persisted unsupported image attachments, not UI layout.
Checklist