fix(app): restore deferred MCP status updates#30220
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Solid Query reactivity pitfall in the app’s global-sync child store where a deferred/initially-disabled MCP query was placed inside a destructured useQueries() array, preventing later-enabled MCP status updates from propagating to the UI (desktop status popover).
Changes:
- Move the deferred MCP status query out of the destructured
useQueries()group into its ownuseQuery()so enabling it later updates the observed result. - Keep the existing grouped
useQueries()setup for path/LSP/providers unchanged. - Update unit tests to mock and assert the new standalone MCP query behavior, including MCP becoming visible after deferred enablement.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/app/src/context/global-sync/child-store.ts | Separates MCP into a standalone useQuery() while keeping other directory queries grouped, restoring reactive MCP status updates after deferred enablement. |
| packages/app/src/context/global-sync/child-store.test.ts | Adjusts mocks and assertions to validate the standalone MCP query enable/disable flow and data visibility after enabling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jun 2, 2026
Closed
Closed
ShamirSecret
pushed a commit
to ShamirSecret/auto-code-machine
that referenced
this pull request
Jun 2, 2026
0xLLLLH
pushed a commit
to 0xLLLLH/opencode
that referenced
this pull request
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useQueries()while it was disabled. When it was enabled later,useQueries()replaced that array entry and the child store kept reading the original disabled result, so the request completed without appearing in the status popover.useQuery... functions side-by-side" and reserveuseQueries()for when "the number of queries you need to execute changes." These are four fixed directory queries, so use individualuseQuery()observers and keep MCP lazy withenabled: mcpEnabled().