Fix: Normalize Mistral tool call IDs to comply with API requirements#3080
Closed
simonfr wants to merge 1 commit intoanomalyco:devfrom
Closed
Fix: Normalize Mistral tool call IDs to comply with API requirements#3080simonfr wants to merge 1 commit intoanomalyco:devfrom
simonfr wants to merge 1 commit intoanomalyco:devfrom
Conversation
Mistral API requires tool call IDs to be exactly 9 characters containing only [a-zA-Z0-9]. Refactored normalizeToolCallIds to accept a transform function, allowing provider-specific ID formatting. Fixes anomalyco#1680
|
Since #2440 was merged, I think this PR is not necessary, anymore. |
772b621 to
eb855e1
Compare
f1dc981 to
3e15a39
Compare
f8ee907 to
6a9856d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1680
Summary
This pull request addresses an incompatibility with the Mistral API's requirements for tool call IDs. The Mistral API expects tool call IDs to be exactly 9 characters long and contain onlyalphanumeric characters (
a-z,A-Z,0-9).The previous implementation generated longer IDs with a
call_prefix, causing tool calls to fail. This change updates the ID generation logic to produce compliant IDs, ensuring thattool-dependent workflows function correctly with Mistral models.