fix(i18n): translate Windows desktop app menu (File/Edit/View/Go) for all locales#34103
Open
Lib-LOCALE wants to merge 1 commit into
Open
fix(i18n): translate Windows desktop app menu (File/Edit/View/Go) for all locales#34103Lib-LOCALE wants to merge 1 commit into
Lib-LOCALE wants to merge 1 commit into
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28797
Type of change
What does this PR do?
The Windows desktop app menu items (File, Edit, View, Go, Window, Help) were hardcoded in English in \desktop-menu.ts\ and bypassed the i18n system entirely. When the app language was set to a non-English locale, the menu stayed in English.
This PR adds a \labelKey\ field to the menu item types that maps to i18n translation keys. The \WindowsAppMenu\ component now looks up translations via \useI18n(), falling back to the English label when no key is present. French translations for all menu items are included — other locales can add theirs in the same way.
How did you verify your code works?
Reviewed all 4 modified files for correctness: types are backward-compatible (optional field), the component uses the existing \useI18n\ pattern already used elsewhere in the app, and translation keys follow the existing naming conventions.
Checklist