fix: resolve @file references in slash commands with subagents #4221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
nice thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
@filereferences in custom slash commands were not resolvedwhen the command specified
agent: <subagent>.Problem
When a slash command used both
@filereferences andagent: foo, the file referenceswere passed literally to the subagent instead of being resolved to actual file
contents. This worked correctly for normal commands but failed for subagent
dispatch.
Solution
Extracted
resolvePromptParts()function and reused it in the task tool pipeline(
packages/opencode/src/tool/task.ts:68) to ensure@filereferences are resolvedbefore subagent execution, matching the behavior of normal command handling.