fix: update reasoningEffort logic for gpt-5.1 models in SessionPrompt-ensureTitle#4456
Merged
rekram1-node merged 2 commits intoanomalyco:devfrom Nov 18, 2025
Merged
fix: update reasoningEffort logic for gpt-5.1 models in SessionPrompt-ensureTitle#4456rekram1-node merged 2 commits intoanomalyco:devfrom
rekram1-node merged 2 commits intoanomalyco:devfrom
Conversation
Contributor
Author
|
Ref: #4451 |
Collaborator
|
@WAY29 do we need that fallback to none? I think just the gpt-5.1 case should do it right |
Collaborator
|
Im just gonna use the immediate fix im not sure that default would work across the board? So ill just do this for now |
Collaborator
|
/oc read the changes made in this pr, make this override existing change: |
Contributor
|
The override has been implemented. The new logic now:
This simplifies the logic by removing the fallback to "none" and the specific "-5-" pattern matching, as requested. |
Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
Contributor
Author
OK, fallback to None was a design choice I made with compatibility in mind for the future gpt model; this solution is also applicable now. |
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
…-ensureTitle (anomalyco#4456) Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.