Skip to content

Add keybindable commands to navigate between user messages #5078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rekram1-node merged 4 commits into from
Dec 22, 2025
Merged

Add keybindable commands to navigate between user messages #5078

rekram1-node merged 4 commits into from
Dec 22, 2025

Conversation

@will-marella
Copy link
Contributor

@will-marella will-marella commented Dec 4, 2025

Closes #5077

Implements configurable keybinds to jump between user messages in chat.

  • Defaults to "none" to avoid keybind collisions
  • Snaps directly to user message boundaries
  • Updated keybinds.mdx documentation

@will-marella will-marella mentioned this pull request Dec 4, 2025
Open
1 task
@dbpolito
Copy link
Contributor

dbpolito commented Dec 4, 2025 •
edited
Loading

This is awesome!!

I would add default to <leader>+up and <leader>+down.

@rekram1-node
Copy link
Collaborator

rekram1-node commented Dec 4, 2025

intentionally not setting default to avoid issues rn, we can add a default later on. Some keybind stuff is in flux rn

@rekram1-node
Copy link
Collaborator

rekram1-node commented Dec 4, 2025

/review

@ariane-emory
Copy link
Contributor

ariane-emory commented Dec 4, 2025

@will-marella This should probably include a check similar to !part.synthetic && !part.ignored to avoid moving to messages that were actually produced by plugins and not typed by the user. Moving between plugin-produced messages is likely not the behaviour that was intended or that users would expect from these commands.

@will-marella will-marella changed the title Add keybind to navigate between user messages Add keybindable commands to navigate between user messages Dec 4, 2025
@will-marella
Copy link
Contributor Author

will-marella commented Dec 4, 2025

@will-marella This should probably include a check similar to !part.synthetic && !part.ignored to avoid moving to messages that were actually produced by plugins and not typed by the user. Moving between plugin-produced messages is likely not the behaviour that was intended or that users would expect from these commands.

This filter is now added with the same logic as messages_last_user

@rekram1-node
Copy link
Collaborator

rekram1-node commented Dec 5, 2025

/review

github-actions[bot]
github-actions bot reviewed Dec 5, 2025
View reviewed changes
github-actions[bot]
github-actions bot reviewed Dec 5, 2025
View reviewed changes
github-actions[bot]
github-actions bot reviewed Dec 5, 2025
View reviewed changes
Will@Cambridge and others added 4 commits December 5, 2025 10:26
Add keybind to navigate between user messages - Adds configurable key…
1611d05 
…bind (defaults to 'none') - Snaps to previous/next user message boundaries - Updates keybinds documentation Closes anomalyco#5077”
Refactor: Extract scrollToMessage helper to reduce duplication
0397c1d
Filter synthetic and ignored messages in navigation
e9fb00f
Address code review feedback
7d4d86b 
- Type dialog parameter with ReturnType<typeof useDialog>
- Use non-mutating reverse with spread operator
- Deduplicate dialog.clear() using guard clause pattern

The bot suggested using else to avoid duplication, but the style guide
discourages else statements. Used early return guard clause instead,
which achieves the same deduplication while following style conventions.
@will-marella will-marella force-pushed the feature/navigate-between-messages branch from 3481141 to 7d4d86b Compare December 5, 2025 15:26
@will-marella
Copy link
Contributor Author

will-marella commented Dec 5, 2025

Rebased on latest dev and addressed all code review feedback:

Typed dialog parameter with ReturnType
Used non-mutating reverse with spread operator
Refactored to guard clause pattern to deduplicate dialog.clear() while avoiding else per style guide

Note: Pushed with --no-verify due to typecheck errors in upstream packages unrelated to this PR. My changes typecheck cleanly when checked in isolation.

@rekram1-node
Copy link
Collaborator

rekram1-node commented Dec 22, 2025

/review

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

lgtm

@rekram1-node rekram1-node merged commit af214d3 into anomalyco:dev Dec 22, 2025
3 checks passed
iljod pushed a commit to iljod/opencode that referenced this pull request Dec 23, 2025
@will-marella @iljod
Add keybindable commands to navigate between user messages (anomalyco…
86ccb16 
…#5078)

Co-authored-by: Will@Cambridge <willcambridge@MacBook-Pro-59.local>
Co-authored-by: Will@Cambridge <willcambridge@macbookpro.mynetworksettings.com>
rekram1-node pushed a commit that referenced this pull request Dec 27, 2025
@will-marella @rekram1-node
Add keybindable commands to navigate between user messages (#5078)
e81c496 
Co-authored-by: Will@Cambridge <willcambridge@MacBook-Pro-59.local>
Co-authored-by: Will@Cambridge <willcambridge@macbookpro.mynetworksettings.com>
anntnzrb pushed a commit to anntnzrb/opencode-1 that referenced this pull request Dec 29, 2025
@will-marella @anntnzrb
Add keybindable commands to navigate between user messages (anomalyco…
0515a8a 
…#5078)

Co-authored-by: Will@Cambridge <willcambridge@MacBook-Pro-59.local>
Co-authored-by: Will@Cambridge <willcambridge@macbookpro.mynetworksettings.com>
github-actions bot pushed a commit to yuguorui/opencode that referenced this pull request Jan 18, 2026
@will-marella
Add keybindable commands to navigate between user messages (anomalyco…
ab12460 
…#5078)

Co-authored-by: Will@Cambridge <willcambridge@MacBook-Pro-59.local>
Co-authored-by: Will@Cambridge <willcambridge@macbookpro.mynetworksettings.com>
burgercrisis pushed a commit to burgercrisis/opencode that referenced this pull request Jan 21, 2026
@will-marella @burgercrisis
Add keybindable commands to navigate between user messages (anomalyco…
f0ba460 
…#5078)

Co-authored-by: Will@Cambridge <willcambridge@MacBook-Pro-59.local>
Co-authored-by: Will@Cambridge <willcambridge@macbookpro.mynetworksettings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add keybind to navigate between user messages

4 participants

@will-marella @dbpolito @rekram1-node @ariane-emory