fix: Perform snapshot in cases finish-step is not reached #5912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamzbr
changed the title
Collaborator
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rekram1-node
changed the title
shuv1337
pushed a commit
to Latitudes-Dev/shuvcode
that referenced
this pull request
Dec 22, 2025
…5912) Co-authored-by: noamzbr <noamzbr@users.noreply.github.com>
oneopane
pushed a commit
to oneopane/opencode
that referenced
this pull request
Dec 23, 2025
…5912) Co-authored-by: noamzbr <noamzbr@users.noreply.github.com>
rekram1-node
pushed a commit
that referenced
this pull request
Dec 27, 2025
Co-authored-by: noamzbr <noamzbr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5911
When snapshots are enabled, we may have untracked files when a snapshot is set at start-step, but finish-step is never reached - for example due to a user cancellation.
This PR adds an explicit patch and updatePart at the end of the process method, if snapshot is still not undefined.
Tested against the script in #5911