fix(tui): prevent keybinds from executing when dialog is open #6017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/review |
Contributor
|
lgtm |
rekram1-node
pushed a commit
that referenced
this pull request
Dec 27, 2025
anntnzrb
added a commit
to anntnzrb/opencode-1
that referenced
this pull request
Dec 29, 2025
Clouder0
added a commit
to Clouder0/overcode
that referenced
this pull request
Jan 4, 2026
Merged upstream dev changes into my_dev job system branch. Conflicts resolved: - sidebar.tsx: Combined job system UI with upstream TodoItem and MCP count helpers - compaction.ts: Kept InvalidTool + added upstream prompt replacement feature - retry.test.ts: Kept both test suites (socket error + ECONNRESET tests) Upstream features merged: - Prompt stashing (anomalyco#6021) - Did you know tips (anomalyco#5982) - MCP OAuth debug command (anomalyco#5980) - Cloudflare AI Gateway (anomalyco#5174) - Install CLI flags (anomalyco#5885) - Windows CRLF grep fix (anomalyco#5948) - Dialog keybind blocking fix (anomalyco#6017) - Model filtering fix (anomalyco#6053)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tabfor agent cycling) executing in the background when a dialog/picker is openDetails
Added
dialog.stack.length > 0guard to theuseKeyboardhandler ininit()to prevent registered command keybinds from firing when a dialog is open. This follows the same pattern already used inCommandProvider(line 102) andsession/index.tsx(line 254).Fixes #6016