fix(lsp): ESLint LSP server fails to auto-install on Windows #6366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
npm.cmdinstead ofnpmon Windows for running install and compile commands during ESLint LSP server installation--max-old-space-sizeV8 flag (Bun uses JavaScriptCore, not V8)Problem
On Windows,
npmis actuallynpm.cmd(a batch file wrapper). Bun's shell may not correctly resolve barenpmcommands, causing the ESLint server installation to fail silently.Additionally, the
--max-old-space-size=8192flag is a V8/Node.js flag, but Bun uses JavaScriptCore. This flag is ignored or could cause unexpected behavior.Solution
This follows the same pattern used by other LSP implementations in the codebase (e.g., Oxlint at line 232-234).
Fixes #6365