fix: use case-insensitive path comparison on Windows to prevent duplicate projects#6626
Open
usvimal wants to merge 2 commits intoanomalyco:devfrom
Open
fix: use case-insensitive path comparison on Windows to prevent duplicate projects#6626usvimal wants to merge 2 commits intoanomalyco:devfrom
usvimal wants to merge 2 commits intoanomalyco:devfrom
Conversation
On Windows, the directory selector was limited to browsing within the user's home directory (C:\Users\<username>). This made it impossible to open projects on other drives like D:\ or outside the user profile. Changes: - Add isAbsolutePath() to detect Windows drive letters and Unix paths - Add getSearchRoot() to extract search directory from absolute paths - Modify fetchDirs() to search from absolute paths when detected - Update placeholder text to hint absolute path support Fixes anomalyco#6490
…cate projects On Windows, file paths are case-insensitive but the project deduplication check used strict equality (===). This caused the same directory opened with different casing (e.g., C:\Users vs c:\Users) to appear as separate entries in the sidebar. Added isWindows() and pathsEqual() helper functions that perform case-insensitive comparison on Windows while maintaining case-sensitive comparison on other platforms.
Contributor
|
@Hona can you take a look? |
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, file paths are case-insensitive but the project deduplication check used strict equality (
===). This caused the same directory opened with different casing (e.g.,C:\Usersvsc:\Users) to appear as separate entries in the sidebar.Changes
isWindows()helper to detect Windows platformpathsEqual()helper for case-insensitive path comparison on Windowsprojects.open/close/expand/collapse/moveto usepathsEqual()Testing
Tested on Windows 11 - opening the same directory with different path casing no longer creates duplicate sidebar entries.