feat(bash): stream large output to tmpfile with filtering and GC #8953
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:PR #6048 - "feat('bash'): Bash tool output saves the stdout/stderr to a file if it exceeds the limit" This PR appears to be directly related to the current PR #8953. Both address:
There's also a tangentially related PR: PR #7049 - "fix: clear tool output and attachments when pruning to prevent memory leak" This PR addresses memory management in tool output, which relates to the memory optimization goal of the current PR. The most likely duplicate is PR #6048, which implements very similar functionality. You may want to check if it was closed, merged, or if the current PR #8953 supersedes it with additional features (like the |
cgwalters
force-pushed
the
bash-auto-redirect
branch
from
3f26c22 to
59b6d76
Compare
Extract formatSize from uninstall.ts to src/util/format.ts for reuse. Assisted-by: OpenCode (Claude Sonnet 4)
Stream command output directly to a temp file when it exceeds 50KB, avoiding memory bloat for commands with huge output. Inspired by block/goose#2817. New feature: - output_filter param: pass a regex (e.g. "^(warning|error):") to capture only matching lines inline while full output goes to file Both filtered and non-filtered modes buffer in memory until the threshold is exceeded, avoiding unnecessary filesystem I/O for small output. The agent is informed that Grep and Read can be used to analyze the temp files. UI now shows filtered output stats (e.g. "Filtered: 7 matches from 2.1 KB (1.9 KB omitted)") so users can see how much output was filtered and the total size. Assisted-by: OpenCode (Claude Sonnet 4)
cgwalters
force-pushed
the
bash-auto-redirect
branch
from
59b6d76 to
0967da8
Compare
1 participant
What does this PR do?
Stream command output directly to a temp file when it exceeds 50KB,
avoiding memory bloat for commands with huge output. Inspired by
block/goose#2817.
New feature:
capture only matching lines inline while full output goes to file
The agent is informed that Grep and Read can be used to analyze the
temp files.
UI now shows filtered output stats (e.g. "Filtered: 7 matches from
2.1 KB (1.9 KB omitted)") so users can see how much output was
filtered and the total size.
Assisted-by: OpenCode (Opus 4.5)
How did you verify your code works?
Unit tests, and also by trying it out directly. (Though I only lightly tested it interactively)