fix: Windows snapshot fails with non-ASCII filenames (Chinese, Japanese, etc.) #9844
+106
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, Bun's $ template literal incorrectly handles variable interpolation, replacing variables with placeholders like ?__bunstr_0 instead of actual values. This causes: - git add . to silently fail adding non-ASCII filenames to snapshot - git checkout / git ls-tree to fail finding files during revert - Undo command only reverts conversation but not code changes Solution: Replace all $ template calls with Bun.spawn() which correctly passes arguments as an array, bypassing shell interpolation issues. Tested on Windows 11 with Chinese filenames - undo now correctly reverts files.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: PR #9408: test(snapshot): add extended test cases for revert functionality This PR is related as it addresses snapshot and revert functionality testing, which is directly relevant to the snapshot/revert issues being fixed in PR #9844. However, this appears to be a test PR rather than a fix for the same issue, so it's more of a complementary PR than a true duplicate. No duplicate PRs found addressing the same Windows non-ASCII filename snapshot issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix undo/revert not working on Windows when project contains non-ASCII filenames (e.g., Chinese, Japanese, Korean characters).
Problem
On Windows, Bun's dollar template literal incorrectly handles variable interpolation, replacing variables with placeholders like
?__bunstr_0instead of actual values. This causes:git add .to silently fail adding non-ASCII filenames to snapshotgit checkout/git ls-treeto fail finding files during revertRoot Cause
The Bun shell template on Windows fails to interpolate variables correctly.
Solution
Replace all dollar template calls with
Bun.spawn()which correctly passes arguments as an array, bypassing shell interpolation issues.Testing
Tested on Windows 11 with project containing Chinese filenames:
Related Issues