Skip to content

Complete code injection fix by removing remaining GitHub expression in shell script#118

Merged
anoncam merged 2 commits intoalert-autofix-19from
copilot/sub-pr-117
Mar 2, 2026
Merged

Complete code injection fix by removing remaining GitHub expression in shell script#118
anoncam merged 2 commits intoalert-autofix-19from
copilot/sub-pr-117

Conversation

Copy link
Contributor

Copilot AI commented Feb 28, 2026

Addresses review feedback on PR #117 - the original fix migrated RELEASE_VERSION to an environment variable but left steps.create_release.outputs.url directly interpolated in the shell script.

Changes:

  • Map steps.create_release.outputs.url to RELEASE_URL environment variable
  • Reference via $RELEASE_URL in echo statement instead of ${{ ... }} expression

Before:

- name: Release complete
  env:
    RELEASE_VERSION: ${{ steps.version.outputs.version }}
  run: |
    echo "Version: v$RELEASE_VERSION"
    echo "Release URL: ${{ steps.create_release.outputs.url }}"

After:

- name: Release complete
  env:
    RELEASE_VERSION: ${{ steps.version.outputs.version }}
    RELEASE_URL: ${{ steps.create_release.outputs.url }}
  run: |
    echo "Version: v$RELEASE_VERSION"
    echo "Release URL: $RELEASE_URL"

This completes the pattern of keeping GitHub expressions in env: declarations while using native shell variable expansion in run: blocks, eliminating CodeQL's code injection alert.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Co-authored-by: anoncam <46797044+anoncam@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix code injection issue in code scanning alert Complete code injection fix by removing remaining GitHub expression in shell script Feb 28, 2026
@anoncam anoncam merged commit 9e0fdec into alert-autofix-19 Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants