Lowercase send-flow step titles (polish)#32
Merged
Conversation
PR anonmesh#29 removed the H_PAD constant when moving PendingCosigns into WalletScreen's grid (parent now owns horizontal padding) but left one reference at line 57. Result: upstream/v3 fails tsc on a fresh clone. Drop the stale paddingHorizontal entry from the wrap View style array and consolidate the two duplicate @expo/vector-icons imports while in the file.
Send-flow scaffold titles were title-case (Set amount, Review, Transfer in motion) which read as shouty in a UI where the rest of the heading hierarchy is lowercase. Lowercased to match the AnonMesh chrome voice. Subtitles (sentence-case copy) and the kicker (textTransform:uppercase in CSS) untouched. RecipientPicker's screen title was already lowercase. Wave A.3 from POLISH_PLAN.
epicexcelsior
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Polishes copy consistency in the send flow by lowercasing scaffold step titles to match the app’s “chrome voice”, and includes a small wallet-lane layout/import cleanup aligned with the shared H_PAD cherry-pick approach mentioned in the PR description.
Changes:
- Lowercase send-flow scaffold titles in
AmountKeypad,ReviewCard, andSuccessCard. - Consolidate icon imports and remove redundant horizontal padding in
PendingCosigns(wallet grid owns padding).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mobile_app/components/send/SuccessCard.tsx | Lowercases the success-step scaffold title (“transfer in motion”). |
| mobile_app/components/send/ReviewCard.tsx | Lowercases the review-step scaffold title (“review”). |
| mobile_app/components/send/AmountKeypad.tsx | Lowercases the amount-step scaffold title (“set amount”). |
| mobile_app/components/nodes/PendingCosigns.tsx | Combines icon imports and removes extra horizontal padding so the wallet grid’s padding is authoritative. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lowercase the three send-flow scaffold step titles for consistency with the rest of the AnonMesh chrome voice.
`RecipientPicker` was already lowercase. Subtitles (sentence-case copy) and the kicker (rendered uppercase by CSS `textTransform`) untouched.
Pure visual polish — no behavior change. Wave A.3 from `POLISH_PLAN.md`.
Wave A.1 (square `ActionRow` outlines) is deferred. The action buttons on the wallet screen are an inline `ActionTiles` in `screens/WalletScreen.tsx:116` (D-lane bento), not the standalone `components/home/ActionRow.tsx` (which turns out to be unused dead code). Will follow up with a Djason heads-up before touching the inline component.
Carries the same `H_PAD` cherry-pick the other wallet-lane PRs do — no-ops on whichever PR merges first.
Test plan