Skip to content

macOS voice/video calls, camera permission, logging, and doc updates#2

Merged
anonymoussoft merged 1 commit intomasterfrom
feature/macos-calls-and-docs
Mar 13, 2026
Merged

macOS voice/video calls, camera permission, logging, and doc updates#2
anonymoussoft merged 1 commit intomasterfrom
feature/macos-calls-and-docs

Conversation

@anonymoussoft
Copy link
Copy Markdown
Owner

  • Audio: start capture on desktop when permission not yet granted (trigger system dialog); reduce PCM log noise (setLogLevel.none)
  • Video: use camera_macos on macOS (camera plugin not implemented); ARGB→YUV conversion; local preview via Texture
  • Docs: TROUBLESHOOTING macOS voice/video section (entitlements, permissions, log checks)
  • Login/settings/export and runtime coordinator updates

Made-with: Cursor

- Audio: start capture on desktop when permission not yet granted (trigger system dialog); reduce PCM log noise (setLogLevel.none)
- Video: use camera_macos on macOS (camera plugin not implemented); ARGB→YUV conversion; local preview via Texture
- Docs: TROUBLESHOOTING macOS voice/video section (entitlements, permissions, log checks)
- Login/settings/export and runtime coordinator updates

Made-with: Cursor
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 505fd887d1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +251 to +254
_capturing = false;
_usingMacOSCamera = false;
_macosTextureId = null;
notifyListeners();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Tear down camera_macos when stream startup fails

If CameraMacOS.instance.initialize(...) succeeds but startImageStream(...) throws (for example, permission denial after initialization or device-busy errors), this catch path only resets Dart-side flags and never calls CameraMacOS.instance.destroy(). That leaves the native camera session allocated, so later capture attempts in the same app run can fail with the camera still in-use/initialized until restart.

Useful? React with 👍 / 👎.

@anonymoussoft anonymoussoft merged commit 00bbcb5 into master Mar 13, 2026
1 check failed
@anonymoussoft anonymoussoft deleted the feature/macos-calls-and-docs branch March 13, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant