macOS voice/video calls, camera permission, logging, and doc updates#2
Conversation
- Audio: start capture on desktop when permission not yet granted (trigger system dialog); reduce PCM log noise (setLogLevel.none) - Video: use camera_macos on macOS (camera plugin not implemented); ARGB→YUV conversion; local preview via Texture - Docs: TROUBLESHOOTING macOS voice/video section (entitlements, permissions, log checks) - Login/settings/export and runtime coordinator updates Made-with: Cursor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 505fd887d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _capturing = false; | ||
| _usingMacOSCamera = false; | ||
| _macosTextureId = null; | ||
| notifyListeners(); |
There was a problem hiding this comment.
Tear down camera_macos when stream startup fails
If CameraMacOS.instance.initialize(...) succeeds but startImageStream(...) throws (for example, permission denial after initialization or device-busy errors), this catch path only resets Dart-side flags and never calls CameraMacOS.instance.destroy(). That leaves the native camera session allocated, so later capture attempts in the same app run can fail with the camera still in-use/initialized until restart.
Useful? React with 👍 / 👎.
Made-with: Cursor