refactor: split home_page and settings_page into part files#3
refactor: split home_page and settings_page into part files#3anonymoussoft merged 1 commit intomasterfrom
Conversation
- home_page: extract persistence (home_page_persistence.dart), plugins (home_page_plugins.dart), and session bootstrap init (home_page_bootstrap.dart) via part/extension; add _bootstrapSetState for extension setState usage - settings_page: extract UI widgets (_HoverableSettingsRow, _AccountCardItem) to settings_page_widgets.dart and list content to settings_page_build.dart (_buildSettingsChildren); add _settingsSetState - Other: tim_sdk_initializer, account_summary model, and related session/bootstrap/account changes Made-with: Cursor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86483f2396
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| keysToRemove.add(_passwordSaltKey(toxId)); | ||
|
|
||
| // 3) Legacy single-account keys: remove only when clearing current account | ||
| if (current == toxId) { |
There was a problem hiding this comment.
Guarding legacy key removal behind current == toxId leaves _kNickname, _kStatusMsg, and _kAutoLogin behind when an account is deleted from the login page after logout (where current_account_tox_id is already null). That stale state is still consumed by startup (main.dart reads nickname/auto-login first), so the app can treat a deleted account as still configured and enter the legacy auto-login path. Please clear legacy login identity keys when deleting the target account in this context (at least when no matching account remains).
Useful? React with 👍 / 👎.
1 participant
Made-with: Cursor