Skip to content

Replaced deprecated apt tool with annotation processing API#4

Merged
dvayanu merged 11 commits into
anotheria:masterfrom
dheid:master
May 18, 2016
Merged

Replaced deprecated apt tool with annotation processing API#4
dvayanu merged 11 commits into
anotheria:masterfrom
dheid:master

Conversation

@dheid
Copy link
Copy Markdown

@dheid dheid commented May 16, 2016

Since the apt tool is no longer supported in Java 8, I replaced the apt usage with the recommended classes according to the blog entry of Joseph D. Darcy:

https://blogs.oracle.com/darcy/entry/an_apt_replacement

Since a lot of imports changed, I needed to optimize the imports later on. This leeds to a bunch of changes on mainly untouched files. Sorry about that! But at least we can use distribute me in the future!

@dvayanu
Copy link
Copy Markdown
Member

dvayanu commented May 17, 2016

Hi Daniel,
thank you very much for your pull request, this is awesome and a whole lot of work you put into it. Since the commits are rather huge, allow us please to spend some hours to review them, before we merge.
Thank you again, your effort is much appreciated!

@dheid
Copy link
Copy Markdown
Author

dheid commented May 17, 2016

Thank you, too! I fixed another major bug with combined service names please also review commit 0c02b69

@dvayanu dvayanu merged commit 08909d6 into anotheria:master May 18, 2016
@dvayanu
Copy link
Copy Markdown
Member

dvayanu commented May 18, 2016

I've merged this pull request. I also raised the version string to 2.3.0 since the change is too serious for a minor update. In the next couple of days we will test the compatibility with other applications, you are invited to test too ,-)

@dvayanu
Copy link
Copy Markdown
Member

dvayanu commented May 20, 2016

'Funny' thing, after the merge the CI job stoped working:
https://jenkins.opensource.anotheria.net/jenkins/view/DistributeMe/job/distributeme_ci/1014/console
I tried to upgrade JDK to latest Java 8 jdk, but it didn't help. Any ideas?

dvayanu pushed a commit that referenced this pull request Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants