Dev/lister plugins (Core functionalyti)#100
Merged
anovik merged 22 commits intoanovik:mainfrom Sep 30, 2024
Merged
Conversation
…tCommander into dev/Lister_plugins
5 tasks
anovik
reviewed
Sep 29, 2024
Owner
anovik
left a comment
anovik
left a comment
There was a problem hiding this comment.
Looks good, can you address a couple of comments.
In general, I think it is better to support plugins only for Windows.
|
|
||
| <!-- Windows 10 --> | ||
| <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}" /> | ||
|
|
Owner
There was a problem hiding this comment.
What about Windows 11, can you add it? I can test if necessary
Contributor
Author
There was a problem hiding this comment.
10 and 11 are the same
Contributor
Author
There was a problem hiding this comment.
U can check but need extract plugin in same folder
| } | ||
| private void OnWindowOpened(object? sender, EventArgs e) | ||
| { | ||
|
|
Owner
There was a problem hiding this comment.
please remove extra lines in this function
anovik
approved these changes
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 part of Feature. (Core functionalyti)
in next PR we will handle other tasksss..