Feature/save eligible voters list#129
Merged
perkynades merged 17 commits intodevelopfrom Mar 11, 2021
Merged
Conversation
freshfish70
requested changes
Mar 10, 2021
Comment on lines
+46
to
+49
| // @MinDate(new Date(), { | ||
| // groups: ['creation'], | ||
| // always: false | ||
| // }) |
Contributor
Author
There was a problem hiding this comment.
It throws error, even when the dates are set correctly. I have written an issue on it
…t' into feature/save-eligible-voters-list
Contributor
Author
|
The tests failing are due to a bug in the date constraints of "ElectionEntity", i have commented these out to not get an error in compilation. But as i have commented these out, some of the tests fail. |
spiftire
approved these changes
Mar 11, 2021
freshfish70
approved these changes
Mar 11, 2021
added 2 commits
March 11, 2021 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121
This pull request is closely related to pull request nr. 115 at frontend