Merged
Conversation
added 7 commits
March 11, 2021 15:55
sanderhurlen
approved these changes
Mar 16, 2021
Contributor
sanderhurlen
left a comment
sanderhurlen
left a comment
There was a problem hiding this comment.
Great work. My vote was submitted in the database 🚀
I think we should guard ourselves against some common scenarios though. Right know, typeorm is doing all the heavy lifting 🏋🏼
Also see my PR about some semantic changes to your code 💋
spiftire
reviewed
Mar 17, 2021
Contributor
spiftire
left a comment
spiftire
left a comment
There was a problem hiding this comment.
Some minor fixes before merge.
We should avoid too generic naming. data and callback are used in JS as general terms, but naming something should indicate what it is or what it does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11