Feature/prevent duplicate ballots#154
Merged
freshfish70 merged 4 commits intodevelopfrom Apr 13, 2021
Merged
Conversation
perkynades
approved these changes
Apr 9, 2021
Comment on lines
+29
to
+51
| if (room.ballots.has(ballotId)) { | ||
| // All voters that has voted on this ballot | ||
| const ballotVotes = room.ballots.get(ballotId)?.voters | ||
| if (ballotVotes?.size == 0) { | ||
| // Send to all as no one has voted on the ballot | ||
| event.server.to(electionId.toString()).emit(Events.server.ballot.push, ballot) | ||
| } else { | ||
| // Get all socket IDs for the socket room that the ballot belongs to | ||
| const roomSocketIds = event.server.of('/').adapter.rooms.get(electionId.toString()) | ||
| roomSocketIds?.forEach((socketId) => { | ||
| const socket = event.server.sockets.sockets.get(socketId) as VoterSocket | undefined | ||
| // If the voter socket exist and the voter id for that socket has not voted on the ballot yet | ||
| if (socket && ballotVotes && !ballotVotes.has(socket.voterId)) { | ||
| // Emit the ballot only to those that has not voter on the ballot yet | ||
| socket.emit(Events.server.ballot.push, ballot) | ||
| } | ||
| }) | ||
| } | ||
| } else { | ||
| // Create ballot stats and voter set for the new ballot | ||
| room.ballots.set(ballotId, { stats: new BallotVoteStats(ballot), voters: new Set() }) | ||
| // Broadcast to all since this ballot has not been created before now | ||
| event.server.to(electionId.toString()).emit(Events.server.ballot.push, ballot) |
Contributor
There was a problem hiding this comment.
This does alot and is hard to read what is going on, consider refactoring it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #147