Skip to content

Bugfix/delete election with votes#195

Merged
spiftire merged 11 commits intodevelopfrom
bugfix/delete-election-with-votes
May 10, 2021
Merged

Bugfix/delete election with votes#195
spiftire merged 11 commits intodevelopfrom
bugfix/delete-election-with-votes

Conversation

@spiftire
Copy link
Copy Markdown
Contributor

@spiftire spiftire commented May 8, 2021

closes #184
closes #188

@spiftire spiftire added the bug This is a bug label May 8, 2021
@spiftire spiftire self-assigned this May 8, 2021
@spiftire spiftire added this to the Sprint 18 milestone May 8, 2021
Comment thread src/loaders/typeorm.ts
Comment on lines 17 to 20
synchronize: true,
logging: false,
logging: ['error'],
logger: 'advanced-console',
entities: [`${config.src}/models/**/*.{ts,js}`],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this log ?
It is possible to create an own logger that makes use of Winston
Logger documentation

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it just logs to the console. I'm not sure, to be honest. We can make a custom logger for it, but I thought maybe it was a bit overkill.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize now that my task was to log to winston 🤦🏻‍♂️ I'll write the logger 😎

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. I see you mentioned this custom log functionality in the other PR 🥳

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up using a library for this. Was a bit easier.

Comment thread src/lib/errors/validation/PasswordValidationError.ts Outdated
Copy link
Copy Markdown
Contributor

@sanderhurlen sanderhurlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coolio

Copy link
Copy Markdown
Contributor

@perkynades perkynades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, your tests are failing :P

Comment thread src/services/ElectionOrganizerService.ts
@spiftire
Copy link
Copy Markdown
Contributor Author

Had to rewrite some tests, since the new logging made it possible to see former mistakes 😅

@spiftire spiftire merged commit 0a96f4e into develop May 10, 2021
@spiftire spiftire deleted the bugfix/delete-election-with-votes branch May 10, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This is a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Password is not validated on backend Deleting election fails when has election has ballots with vote submitted

4 participants