Add ORM to backend with db container#30
Merged
sanderhurlen merged 32 commits intodevelopfrom Feb 3, 2021
Merged
Conversation
…ture/CRUD-election
sanderhurlen
added
performance
sanderhurlen
added
infastructure
perkynades
reviewed
Feb 3, 2021
| command: | ||
| [ | ||
| "denon", | ||
| "run --unstable --config tsconfig.json --allow-read --allow-write --allow-net --allow-env ./src/main.ts", |
Contributor
There was a problem hiding this comment.
Maby we should change this so that is starts httpServer.ts
Contributor
Author
There was a problem hiding this comment.
I am only using main.ts to show that the db works. On this PR, I was not interested in starting the HTTP server...
However, I personally feel main should be the main starting point for the application.
spiftire
approved these changes
Feb 3, 2021
Comment on lines
-1
to
-106
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| lerna-debug.log* | ||
|
|
||
| # Diagnostic reports (https://nodejs.org/api/report.html) | ||
| report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json | ||
|
|
||
| # Runtime data | ||
| pids | ||
| *.pid | ||
| *.seed | ||
| *.pid.lock | ||
|
|
||
| # Directory for instrumented libs generated by jscoverage/JSCover | ||
| lib-cov | ||
|
|
||
| # Coverage directory used by tools like istanbul | ||
| coverage | ||
| *.lcov | ||
|
|
||
| # nyc test coverage | ||
| .nyc_output | ||
|
|
||
| # Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files) | ||
| .grunt | ||
|
|
||
| # Bower dependency directory (https://bower.io/) | ||
| bower_components | ||
|
|
||
| # node-waf configuration | ||
| .lock-wscript | ||
|
|
||
| # Compiled binary addons (https://nodejs.org/api/addons.html) | ||
| build/Release | ||
|
|
||
| # Dependency directories | ||
| .idea/ | ||
| .vscode/ | ||
| node_modules/ | ||
| jspm_packages/ | ||
|
|
||
| # TypeScript v1 declaration files | ||
| typings/ | ||
|
|
||
| # TypeScript cache | ||
| *.tsbuildinfo | ||
|
|
||
| # Optional npm cache directory | ||
| .npm | ||
|
|
||
| # Optional eslint cache | ||
| .eslintcache | ||
|
|
||
| # Microbundle cache | ||
| .rpt2_cache/ | ||
| .rts2_cache_cjs/ | ||
| .rts2_cache_es/ | ||
| .rts2_cache_umd/ | ||
|
|
||
| # Optional REPL history | ||
| .node_repl_history | ||
|
|
||
| # Output of 'npm pack' | ||
| *.tgz | ||
|
|
||
| # Yarn Integrity file | ||
| .yarn-integrity | ||
|
|
||
| # dotenv environment variables file | ||
| build/ | ||
| tmp/ | ||
| temp/ | ||
| .env | ||
| .env.test | ||
|
|
||
| # parcel-bundler cache (https://parceljs.org/) | ||
| .cache | ||
|
|
||
| # Next.js build output | ||
| .next | ||
|
|
||
| # Nuxt.js build / generate output | ||
| .nuxt | ||
| dist | ||
|
|
||
| # Gatsby files | ||
| .cache/ | ||
| # Comment in the public line in if your project uses Gatsby and *not* Next.js | ||
| # https://nextjs.org/blog/next-9-1#public-directory-support | ||
| # public | ||
|
|
||
| # vuepress build output | ||
| .vuepress/dist | ||
|
|
||
| # Serverless directories | ||
| .serverless/ | ||
|
|
||
| # FuseBox cache | ||
| .fusebox/ | ||
|
|
||
| # DynamoDB Local files | ||
| .dynamodb/ | ||
|
|
||
| # TernJS port file | ||
| .tern-port | ||
|
|
||
| .DS_Store No newline at end of file |
Contributor
There was a problem hiding this comment.
Should all these be removed?
Contributor
Author
There was a problem hiding this comment.
nope. Def, not. Looks like it overrides the develop file. Its a merge conflict
Contributor
There was a problem hiding this comment.
Should just merge dev before merge then.
Comment on lines
+13
to
+31
| enum BallotType { | ||
| SINGLE, | ||
| MULTIPLE, | ||
| RANKED, | ||
| } | ||
|
|
||
| enum BallotResultDisplay { | ||
| NONE, | ||
| SINGLE, | ||
| RUNNER_UP, | ||
| ALL, | ||
| } | ||
|
|
||
| enum BallotStatus { | ||
| IN_QUEUE, | ||
| IN_PROGRESS, | ||
| IN_RESULT, | ||
| IN_ARCHIVE, | ||
| } |
Contributor
Author
There was a problem hiding this comment.
As of right now, yes. As I don't know why it stops working from a separate file, we would have to use the enums from this file anyway.
Contributor
There was a problem hiding this comment.
At the moment they are not exported though... But probably we will use them in other parts of the project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remember to:
rename 'env.example' to use appropriate variables and rename file to '.env' in your root dirCloses #13