Merged
Conversation
Co-authored-by: Sander Hurlen <sander.hurlen@icloud.com>
…zer-node' into feature/register-election-organizer-node
Co-authored-by: spiftire <44159536+spiftire@users.noreply.github.com>
…er-node Feature/register election organizer node
Quick fix for wrong path and gitignore
perkynades
approved these changes
Feb 11, 2021
Contributor
perkynades
left a comment
perkynades
left a comment
There was a problem hiding this comment.
Very good nice work everyone!
sanderhurlen
approved these changes
Feb 11, 2021
Contributor
sanderhurlen
left a comment
sanderhurlen
left a comment
There was a problem hiding this comment.
🚀 The start of something great! 🚀
Great job on porting from deno to node, boys. 👏🏼
We made it butter smooth 🧈 😋
| } | ||
| } | ||
|
|
||
| private async hashEntityPassword(electionDTO: IElection) { |
Contributor
There was a problem hiding this comment.
Suggested change
| private async hashEntityPassword(electionDTO: IElection) { | |
| private async hashElectionPassword(electionDTO: IElection) { |
1 task
Co-authored-by: Sander Hurlen <sander.hurlen@icloud.com>
Co-authored-by: Sander Hurlen <sander.hurlen@icloud.com>
Co-authored-by: Sander Hurlen <sander.hurlen@icloud.com>
Co-authored-by: Sander Hurlen <sander.hurlen@icloud.com>
Co-authored-by: Sander Hurlen <sander.hurlen@icloud.com>
Co-authored-by: Sander Hurlen <sander.hurlen@icloud.com>
Co-authored-by: Sander Hurlen <sander.hurlen@icloud.com>
Co-authored-by: Sander Hurlen <sander.hurlen@icloud.com>
Co-authored-by: Sander Hurlen <sander.hurlen@icloud.com>
Co-authored-by: Sander Hurlen <sander.hurlen@icloud.com>
Co-authored-by: Sander Hurlen <sander.hurlen@icloud.com>
spiftire
reviewed
Feb 11, 2021
Comment on lines
+1
to
+3
| { | ||
| "recommendations": ["yatki.vscode-surround"] | ||
| } |
Contributor
There was a problem hiding this comment.
I think there are some missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested as built the project; all goes through. Please have a look for typos etc. :D
Closes #67