Skip to content

Feature/change election organizer password#78

Merged
sanderhurlen merged 9 commits intodevelopfrom
feature/change-election-organizer-password
Feb 19, 2021
Merged

Feature/change election organizer password#78
sanderhurlen merged 9 commits intodevelopfrom
feature/change-election-organizer-password

Conversation

@perkynades
Copy link
Copy Markdown
Contributor

Closes #73

Copy link
Copy Markdown
Contributor

@sanderhurlen sanderhurlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some things you need to fix

And you need to clean up your postman requests and use variables so its easier to test.

Comment thread src/api/index.ts Outdated
Comment thread src/models/ElectionOrganizer/IUpdatePassword.ts Outdated
Comment thread src/api/routes/electionOrganizer/index.ts
Comment thread src/services/ElectionOrganizerService.ts Outdated
Comment thread src/services/ElectionOrganizerService.ts Outdated
Comment thread src/api/index.ts Outdated
Comment thread src/api/routes/electionOrganizer/index.ts Outdated
Comment thread src/services/ElectionOrganizerService.ts Outdated
Comment thread src/services/ElectionOrganizerService.ts Outdated
Comment thread src/services/ElectionOrganizerService.ts Outdated
Comment thread src/services/ElectionOrganizerService.ts Outdated
Comment thread src/services/ElectionOrganizerService.ts Outdated
Comment thread src/services/ElectionOrganizerService.ts Outdated
Comment thread src/helpers/IUpdatePassword.ts Outdated
Comment thread src/services/ElectionOrganizerService.ts Outdated
Copy link
Copy Markdown
Contributor

@sanderhurlen sanderhurlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for takeoff 🚀


const electionOrganizer: ElectionOrganizer | undefined = await repository.findOne({
id: idOfElectionOrganizer
id: id
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be id only..

Comment thread src/api/routes/electionOrganizer/index.ts Outdated
Comment thread src/api/routes/electionOrganizer/index.ts Outdated
Comment thread src/api/routes/electionOrganizer/index.ts Outdated
@spiftire spiftire added this to the Sprint 6 milestone Feb 19, 2021
@sanderhurlen sanderhurlen merged commit 6bb45a7 into develop Feb 19, 2021
@sanderhurlen sanderhurlen deleted the feature/change-election-organizer-password branch February 19, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As an electionorganizer i must be able to change my password

4 participants