Skip to content

Feature/error handling middleware with error types#85

Merged
sanderhurlen merged 28 commits intodevelopfrom
feature/error-handling-middleware
Feb 19, 2021
Merged

Feature/error handling middleware with error types#85
sanderhurlen merged 28 commits intodevelopfrom
feature/error-handling-middleware

Conversation

@sanderhurlen
Copy link
Copy Markdown
Contributor

@sanderhurlen sanderhurlen commented Feb 17, 2021

  • refactors all endpoints to send errors to middleware
  • refactors all middleware to send errors to middleware
  • adds error handling middleware

closes #46, #74

@sanderhurlen sanderhurlen added feature A new feature we need to add infastructure Code, work, cloud infastructure related labels Feb 17, 2021
@sanderhurlen sanderhurlen added this to the Sprint 6 milestone Feb 17, 2021
@sanderhurlen sanderhurlen self-assigned this Feb 17, 2021
@sanderhurlen sanderhurlen changed the title Feature/error handling middleware Feature/error handling middleware with error types Feb 17, 2021
@spiftire spiftire self-requested a review February 18, 2021 07:57
@sanderhurlen sanderhurlen marked this pull request as ready for review February 18, 2021 09:42
@sanderhurlen
Copy link
Copy Markdown
Contributor Author

The pr is failing on spellchecking. A issue is created #92 and will be fixed there.

@sanderhurlen sanderhurlen linked an issue Feb 18, 2021 that may be closed by this pull request
7 tasks
Comment thread src/lib/errors/http/NotAcceptableError.ts
Comment thread src/lib/errors/BaseError.ts
Comment thread src/services/AuthenticationService.ts
Comment thread src/services/AuthenticationService.ts
@sanderhurlen sanderhurlen merged commit c20fd96 into develop Feb 19, 2021
@sanderhurlen sanderhurlen deleted the feature/error-handling-middleware branch February 19, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A new feature we need to add infastructure Code, work, cloud infastructure related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup error messages + generation Create HTTP middleware for handling respone errors.

3 participants