Skip to content

Fix default enums#97

Merged
spiftire merged 44 commits intodevelopfrom
feature/default-enums
Feb 24, 2021
Merged

Fix default enums#97
spiftire merged 44 commits intodevelopfrom
feature/default-enums

Conversation

@spiftire
Copy link
Copy Markdown
Contributor

@spiftire spiftire commented Feb 19, 2021

This was a deep one 🐇 This should only add default values to enums but ended up reconfiguring the way tests are run on a DB. We might have some duplicate code for starting the test DB. I have left it in for now.

closes #51

@spiftire spiftire added this to the Sprint 7 milestone Feb 19, 2021
@spiftire spiftire self-assigned this Feb 19, 2021
@spiftire spiftire marked this pull request as draft February 19, 2021 11:03
@spiftire spiftire marked this pull request as ready for review February 22, 2021 12:06
Comment thread src/config/index.ts Outdated
Comment thread src/loaders/setupTestDB.ts
Comment thread tests/models/BallotEntity.test.ts
Comment thread tests/models/ElectionEntity.test.ts Outdated
Copy link
Copy Markdown
Contributor

@perkynades perkynades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, also agree with what Christoffer commented

Comment thread src/config/index.ts
Comment thread tests/services/BallotService.test.ts
@spiftire spiftire requested a review from freshfish70 February 23, 2021 19:59
@spiftire spiftire merged commit 6f0a617 into develop Feb 24, 2021
@spiftire spiftire deleted the feature/default-enums branch February 24, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set default enum value for entities

3 participants