Refactor/uuids websockets autoids#32
Merged
Merged
Conversation
Adds an isDefined and isUndefined function to the utils module for easy checking. Cleans up according to the eslint rules in several places and adds an eslint (lint) task to the gulp file. Right now it is not part of the build because of the number of errors. Someday it will be added once that is more under control.
Turned out to be a pretty minor change but a needed one. should be faster and more secure then the previous method.
All the files there are now in compliance with the eslint standards. Well there are a few warnings left... but no errors at least.
Don't have time right at this very moment to convert it over to the eslint standards. Will get it next. All the outher routes though are now compliant and ready to rock into the future.
No build in place yet so I can't deal with the client side files. And one of the big tasks coming up is getting them into their own project so they aren't super relevant. Also bailed on the gulpfile for now. Will clean it up eventually
also tidys up some functions and switches us over to the UUID generation system instead of hashes
Member
Author
|
closes #25 and gets up to date with eslint mostly |
designfrontier
added a commit
that referenced
this pull request
Dec 15, 2015
Refactor/uuids websockets autoids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.