Replace module should not trigger rule violation #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only copy and template modules support preserve mode permissions: ansible/ansible#56839 (comment) Documentation was fixed in the above MR: ansible/ansible#71486 Also replace module uses atomic_move function that preserves permissions, so we can safely remove this module from a check list.
ssbarnea
approved these changes
Sep 1, 2020
aston-r
deleted the
bugfix/1023-replace-module-should-not-trigger-rule-violation
branch
Member
|
Hey @aston-r, looking at your commit
it appears that you have misconfigured Git on your computer or forgot to add an extra email to your GitHub account. If you wish to fix that, either verify the second email on GitHub or use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only copy and template modules support preserve mode permissions:
ansible/ansible#56839 (comment)
Documentation was fixed in the above MR, but not published yet:
ansible/ansible#71486
Also replace module uses
atomic_movefunction that preserves permissions by default,so we can safely remove this module from a check list.
Fixes: #1023