Gracefully process a missing git binary when falling-back to pure-python discovery #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
suggested changes
Apr 17, 2020
Member
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
I think the regression test should be added to make this mergeable and this will now cause AttributeError (per my comment below).
webknjaz
changed the title
anryko
force-pushed
the
735_fix_missing_git_error
branch
from
79b8a21 to
c058ac2
Compare
anryko
force-pushed
the
735_fix_missing_git_error
branch
from
c058ac2 to
a39a511
Compare
webknjaz
suggested changes
Apr 18, 2020
Member
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
The change seems ok, still waiting for the regression test before I can merge.
Contributor
Author
|
@webknjaz could you suggest how the test should work? |
Member
|
@anryko |
webknjaz
reviewed
Apr 21, 2020
webknjaz
reviewed
Apr 21, 2020
webknjaz
reviewed
Apr 21, 2020
anryko
force-pushed
the
735_fix_missing_git_error
branch
from
e39ae10 to
a85fcb4
Compare
webknjaz
reviewed
Apr 22, 2020
webknjaz
reviewed
Apr 22, 2020
webknjaz
reviewed
Apr 22, 2020
webknjaz
reviewed
Apr 22, 2020
Merged
anryko
force-pushed
the
735_fix_missing_git_error
branch
2 times, most recently
from
eb267d4 to
890c2a2
Compare
webknjaz
reviewed
Apr 23, 2020
anryko
force-pushed
the
735_fix_missing_git_error
branch
from
890c2a2 to
d42f212
Compare
webknjaz
reviewed
Apr 23, 2020
webknjaz
reviewed
Apr 23, 2020
webknjaz
reviewed
Apr 23, 2020
webknjaz
reviewed
Apr 23, 2020
webknjaz
reviewed
Apr 23, 2020
webknjaz
reviewed
Apr 23, 2020
anryko
force-pushed
the
735_fix_missing_git_error
branch
3 times, most recently
from
64622dc to
1397d90
Compare
anryko
force-pushed
the
735_fix_missing_git_error
branch
2 times, most recently
from
a72d841 to
5d5fafa
Compare
webknjaz
reviewed
Apr 23, 2020
webknjaz
reviewed
Apr 23, 2020
anryko
force-pushed
the
735_fix_missing_git_error
branch
2 times, most recently
from
5d5fafa to
13cadb4
Compare
webknjaz
suggested changes
Apr 23, 2020
anryko
force-pushed
the
735_fix_missing_git_error
branch
from
13cadb4 to
4f7ebf6
Compare
webknjaz
approved these changes
Apr 23, 2020
webknjaz
reviewed
Apr 23, 2020
anryko
force-pushed
the
735_fix_missing_git_error
branch
from
4f7ebf6 to
b030311
Compare
Contributor
Author
|
@webknjaz thanks! Great review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #735 by catching an extra corner case
exception
FileNotFoundError.