BENCH-159: change to be compliant with the latest openapi version #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BENCH-161 Refactored codebase
AudriusPutys
approved these changes
Nov 14, 2022
ORybak5
pushed a commit
that referenced
this pull request
Nov 18, 2022
* change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com>
ORybak5
pushed a commit
that referenced
this pull request
Nov 18, 2022
* BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * Bench 42 checkstyle3 (#8) * addig checkstyle * adding .env * adding .env * adding checkstyle rules * Fixing checkstyle errors * Fixing remaining checkstyle errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-79 item controller and service layer tests added. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * BENCH-79 code updated as per comments raised. * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes (#11) * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * reverting the deleted changes * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * checkstyle bug fix (#13) * BENCH-83 Changed application.yaml to disable open-in-view. * BENCH-46 Lombok Implemented and controller test updated to bypass security * Bench 42 checkstyle4 (#16) * adding some other checkstyle rules * adding identation rule * adding more rules * Fixing checkstyle build and test errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](springdoc/springdoc-openapi-maven-plugin@v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](dependabot/fetch-metadata@v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](apache/maven-wrapper@maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * BENCH-184 made removing item from basket transactional Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ORybak5
pushed a commit
that referenced
this pull request
Nov 21, 2022
* BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](springdoc/springdoc-openapi-maven-plugin@v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](dependabot/fetch-metadata@v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](apache/maven-wrapper@maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * adding missing fields as per API spec * adding missing fields as per API spec * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * test adjustments * test adjustments * small method optimization * small method optimization * adding missing fields as per API spec * adding missing fields as per API spec * test adjustments * test adjustments * small method optimization * small method optimization * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * adding missing fields as per API spec * adding missing fields as per API spec * test adjustments * test adjustments * small method optimization * small method optimization * rebase with main * rebase with main * rebase with main * rebase with main * adding full stops * adding full stops * BENCH-184 made removing item from basket transactional * added missed final * adding missing fields as per API spec * test adjustments * small method optimization * rebase with main * rebase with main * rebase * rebase * rebase * rebase * rebase * adding full stops * added missed final * rebase * rebase * rebase with main * rebase with main * rebase * rebase * rebase * removing empty lines * rebase * rebase with main * rebase with main * rebase * rebase * added missed final * rebase * rebase with main * rebase with main * rebase * rebase * rebase Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com>
ORybak5
pushed a commit
that referenced
this pull request
Nov 21, 2022
* BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * Bench 42 checkstyle3 (#8) * addig checkstyle * adding .env * adding .env * adding checkstyle rules * Fixing checkstyle errors * Fixing remaining checkstyle errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-79 item controller and service layer tests added. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * BENCH-79 code updated as per comments raised. * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes (#11) * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * reverting the deleted changes * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * checkstyle bug fix (#13) * BENCH-83 Changed application.yaml to disable open-in-view. * BENCH-46 Lombok Implemented and controller test updated to bypass security * Bench 42 checkstyle4 (#16) * adding some other checkstyle rules * adding identation rule * adding more rules * Fixing checkstyle build and test errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](springdoc/springdoc-openapi-maven-plugin@v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](dependabot/fetch-metadata@v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](apache/maven-wrapper@maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * BENCH-184 made removing item from basket transactional Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ORybak5
pushed a commit
that referenced
this pull request
Nov 21, 2022
* BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](springdoc/springdoc-openapi-maven-plugin@v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](dependabot/fetch-metadata@v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](apache/maven-wrapper@maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * adding missing fields as per API spec * adding missing fields as per API spec * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * test adjustments * test adjustments * small method optimization * small method optimization * adding missing fields as per API spec * adding missing fields as per API spec * test adjustments * test adjustments * small method optimization * small method optimization * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * adding missing fields as per API spec * adding missing fields as per API spec * test adjustments * test adjustments * small method optimization * small method optimization * rebase with main * rebase with main * rebase with main * rebase with main * adding full stops * adding full stops * BENCH-184 made removing item from basket transactional * added missed final * adding missing fields as per API spec * test adjustments * small method optimization * rebase with main * rebase with main * rebase * rebase * rebase * rebase * rebase * adding full stops * added missed final * rebase * rebase * rebase with main * rebase with main * rebase * rebase * rebase * removing empty lines * rebase * rebase with main * rebase with main * rebase * rebase * added missed final * rebase * rebase with main * rebase with main * rebase * rebase * rebase Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com>
ORybak5
pushed a commit
that referenced
this pull request
Nov 21, 2022
* BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * Bench 42 checkstyle3 (#8) * addig checkstyle * adding .env * adding .env * adding checkstyle rules * Fixing checkstyle errors * Fixing remaining checkstyle errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-79 item controller and service layer tests added. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * BENCH-79 code updated as per comments raised. * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes (#11) * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * reverting the deleted changes * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * checkstyle bug fix (#13) * BENCH-83 Changed application.yaml to disable open-in-view. * BENCH-46 Lombok Implemented and controller test updated to bypass security * Bench 42 checkstyle4 (#16) * adding some other checkstyle rules * adding identation rule * adding more rules * Fixing checkstyle build and test errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @Builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](https://github.com/springdoc/springdoc-openapi-maven-plugin/compare/v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](https://github.com/dependabot/fetch-metadata/compare/v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](https://github.com/apache/maven-wrapper/compare/maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * BENCH-184 made removing item from basket transactional * BENCH-56: Bench 56 v2 (#81) * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * Bench 42 checkstyle3 (#8) * addig checkstyle * adding .env * adding .env * adding checkstyle rules * Fixing checkstyle errors * Fixing remaining checkstyle errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-79 item controller and service layer tests added. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * BENCH-79 code updated as per comments raised. * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes (#11) * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * reverting the deleted changes * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * checkstyle bug fix (#13) * BENCH-83 Changed application.yaml to disable open-in-view. * BENCH-46 Lombok Implemented and controller test updated to bypass security * Bench 42 checkstyle4 (#16) * adding some other checkstyle rules * adding identation rule * adding more rules * Fixing checkstyle build and test errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @Builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](https://github.com/springdoc/springdoc-openapi-maven-plugin/compare/v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](https://github.com/dependabot/fetch-metadata/compare/v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](https://github.com/apache/maven-wrapper/compare/maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * BENCH-184 made removing item from basket transactional Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * (fix) update: Bump springdoc-openapi-ui from 1.6.12 to 1.6.13 (#84) Bumps [springdoc-openapi-ui](https://github.com/springdoc/springdoc-openapi) from 1.6.12 to 1.6.13. - [Release notes](https://github.com/springdoc/springdoc-openapi/releases) - [Changelog](https://github.com/springdoc/springdoc-openapi/blob/master/CHANGELOG.md) - [Commits](https://github.com/springdoc/springdoc-openapi/compare/v1.6.12...v1.6.13) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-ui dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * (fix) update: Bump springdoc-openapi-security from 1.6.12 to 1.6.13 (#83) Bumps [springdoc-openapi-security](https://github.com/springdoc/springdoc-openapi) from 1.6.12 to 1.6.13. - [Release notes](https://github.com/springdoc/springdoc-openapi/releases) - [Changelog](https://github.com/springdoc/springdoc-openapi/blob/master/CHANGELOG.md) - [Commits](https://github.com/springdoc/springdoc-openapi/compare/v1.6.12...v1.6.13) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-security dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * (fix) update: Bump PavanMudigonda/jacoco-reporter from 4.6 to 4.7 (#82) Bumps [PavanMudigonda/jacoco-reporter](https://github.com/PavanMudigonda/jacoco-reporter) from 4.6 to 4.7. - [Release notes](https://github.com/PavanMudigonda/jacoco-reporter/releases) - [Commits](https://github.com/PavanMudigonda/jacoco-reporter/compare/v4.6...v4.7) --- updated-dependencies: - dependency-name: PavanMudigonda/jacoco-reporter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bench-173: Aligining Category with API spec (#77) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @Builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](https://github.com/springdoc/springdoc-openapi-maven-plugin/compare/v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](https://github.com/dependabot/fetch-metadata/compare/v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](https://github.com/apache/maven-wrapper/compare/maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * adding missing fields as per API spec * adding missing fields as per API spec * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * test adjustments * test adjustments * small method optimization * small method optimization * adding missing fields as per API spec * adding missing fields as per API spec * test adjustments * test adjustments * small method optimization * small method optimization * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * adding missing fields as per API spec * adding missing fields as per API spec * test adjustments * test adjustments * small method optimization * small method optimization * rebase with main * rebase with main * rebase with main * rebase with main * adding full stops * adding full stops * BENCH-184 made removing item from basket transactional * added missed final * adding missing fields as per API spec * test adjustments * small method optimization * rebase with main * rebase with main * rebase * rebase * rebase * rebase * rebase * adding full stops * added missed final * rebase * rebase * rebase with main * rebase with main * rebase * rebase * rebase * removing empty lines * rebase * rebase with main * rebase with main * rebase * rebase * added missed final * rebase * rebase with main * rebase with main * rebase * rebase * rebase Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ORybak5
pushed a commit
that referenced
this pull request
Nov 21, 2022
* BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * Bench 42 checkstyle3 (#8) * addig checkstyle * adding .env * adding .env * adding checkstyle rules * Fixing checkstyle errors * Fixing remaining checkstyle errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-79 item controller and service layer tests added. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * BENCH-79 code updated as per comments raised. * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes (#11) * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * reverting the deleted changes * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * checkstyle bug fix (#13) * BENCH-83 Changed application.yaml to disable open-in-view. * BENCH-46 Lombok Implemented and controller test updated to bypass security * Bench 42 checkstyle4 (#16) * adding some other checkstyle rules * adding identation rule * adding more rules * Fixing checkstyle build and test errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @Builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](https://github.com/springdoc/springdoc-openapi-maven-plugin/compare/v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](https://github.com/dependabot/fetch-metadata/compare/v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](https://github.com/apache/maven-wrapper/compare/maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * BENCH-184 made removing item from basket transactional * BENCH-56: Bench 56 v2 (#81) * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * Bench 42 checkstyle3 (#8) * addig checkstyle * adding .env * adding .env * adding checkstyle rules * Fixing checkstyle errors * Fixing remaining checkstyle errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-79 item controller and service layer tests added. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * BENCH-79 code updated as per comments raised. * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes (#11) * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * reverting the deleted changes * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * checkstyle bug fix (#13) * BENCH-83 Changed application.yaml to disable open-in-view. * BENCH-46 Lombok Implemented and controller test updated to bypass security * Bench 42 checkstyle4 (#16) * adding some other checkstyle rules * adding identation rule * adding more rules * Fixing checkstyle build and test errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @Builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](https://github.com/springdoc/springdoc-openapi-maven-plugin/compare/v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](https://github.com/dependabot/fetch-metadata/compare/v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](https://github.com/apache/maven-wrapper/compare/maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * BENCH-184 made removing item from basket transactional Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * (fix) update: Bump springdoc-openapi-ui from 1.6.12 to 1.6.13 (#84) Bumps [springdoc-openapi-ui](https://github.com/springdoc/springdoc-openapi) from 1.6.12 to 1.6.13. - [Release notes](https://github.com/springdoc/springdoc-openapi/releases) - [Changelog](https://github.com/springdoc/springdoc-openapi/blob/master/CHANGELOG.md) - [Commits](https://github.com/springdoc/springdoc-openapi/compare/v1.6.12...v1.6.13) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-ui dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * (fix) update: Bump springdoc-openapi-security from 1.6.12 to 1.6.13 (#83) Bumps [springdoc-openapi-security](https://github.com/springdoc/springdoc-openapi) from 1.6.12 to 1.6.13. - [Release notes](https://github.com/springdoc/springdoc-openapi/releases) - [Changelog](https://github.com/springdoc/springdoc-openapi/blob/master/CHANGELOG.md) - [Commits](https://github.com/springdoc/springdoc-openapi/compare/v1.6.12...v1.6.13) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-security dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * (fix) update: Bump PavanMudigonda/jacoco-reporter from 4.6 to 4.7 (#82) Bumps [PavanMudigonda/jacoco-reporter](https://github.com/PavanMudigonda/jacoco-reporter) from 4.6 to 4.7. - [Release notes](https://github.com/PavanMudigonda/jacoco-reporter/releases) - [Commits](https://github.com/PavanMudigonda/jacoco-reporter/compare/v4.6...v4.7) --- updated-dependencies: - dependency-name: PavanMudigonda/jacoco-reporter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bench-173: Aligining Category with API spec (#77) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @Builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](https://github.com/springdoc/springdoc-openapi-maven-plugin/compare/v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](https://github.com/dependabot/fetch-metadata/compare/v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](https://github.com/apache/maven-wrapper/compare/maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * adding missing fields as per API spec * adding missing fields as per API spec * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * test adjustments * test adjustments * small method optimization * small method optimization * adding missing fields as per API spec * adding missing fields as per API spec * test adjustments * test adjustments * small method optimization * small method optimization * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * adding missing fields as per API spec * adding missing fields as per API spec * test adjustments * test adjustments * small method optimization * small method optimization * rebase with main * rebase with main * rebase with main * rebase with main * adding full stops * adding full stops * BENCH-184 made removing item from basket transactional * added missed final * adding missing fields as per API spec * test adjustments * small method optimization * rebase with main * rebase with main * rebase * rebase * rebase * rebase * rebase * adding full stops * added missed final * rebase * rebase * rebase with main * rebase with main * rebase * rebase * rebase * removing empty lines * rebase * rebase with main * rebase with main * rebase * rebase * added missed final * rebase * rebase with main * rebase with main * rebase * rebase * rebase Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ORybak5
pushed a commit
that referenced
this pull request
Nov 21, 2022
* change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com>
ORybak5
pushed a commit
that referenced
this pull request
Nov 21, 2022
* BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * Bench 42 checkstyle3 (#8) * addig checkstyle * adding .env * adding .env * adding checkstyle rules * Fixing checkstyle errors * Fixing remaining checkstyle errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-79 item controller and service layer tests added. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * BENCH-79 code updated as per comments raised. * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes (#11) * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * reverting the deleted changes * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * checkstyle bug fix (#13) * BENCH-83 Changed application.yaml to disable open-in-view. * BENCH-46 Lombok Implemented and controller test updated to bypass security * Bench 42 checkstyle4 (#16) * adding some other checkstyle rules * adding identation rule * adding more rules * Fixing checkstyle build and test errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](springdoc/springdoc-openapi-maven-plugin@v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](dependabot/fetch-metadata@v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](apache/maven-wrapper@maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * BENCH-184 made removing item from basket transactional Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ORybak5
pushed a commit
that referenced
this pull request
Nov 21, 2022
* BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](springdoc/springdoc-openapi-maven-plugin@v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](dependabot/fetch-metadata@v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](apache/maven-wrapper@maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * adding missing fields as per API spec * adding missing fields as per API spec * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * test adjustments * test adjustments * small method optimization * small method optimization * adding missing fields as per API spec * adding missing fields as per API spec * test adjustments * test adjustments * small method optimization * small method optimization * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * adding missing fields as per API spec * adding missing fields as per API spec * test adjustments * test adjustments * small method optimization * small method optimization * rebase with main * rebase with main * rebase with main * rebase with main * adding full stops * adding full stops * BENCH-184 made removing item from basket transactional * added missed final * adding missing fields as per API spec * test adjustments * small method optimization * rebase with main * rebase with main * rebase * rebase * rebase * rebase * rebase * adding full stops * added missed final * rebase * rebase * rebase with main * rebase with main * rebase * rebase * rebase * removing empty lines * rebase * rebase with main * rebase with main * rebase * rebase * added missed final * rebase * rebase with main * rebase with main * rebase * rebase * rebase Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com>
ORybak5
pushed a commit
that referenced
this pull request
Nov 21, 2022
* BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * Bench 42 checkstyle3 (#8) * addig checkstyle * adding .env * adding .env * adding checkstyle rules * Fixing checkstyle errors * Fixing remaining checkstyle errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-79 item controller and service layer tests added. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * BENCH-79 code updated as per comments raised. * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes (#11) * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * reverting the deleted changes * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * checkstyle bug fix (#13) * BENCH-83 Changed application.yaml to disable open-in-view. * BENCH-46 Lombok Implemented and controller test updated to bypass security * Bench 42 checkstyle4 (#16) * adding some other checkstyle rules * adding identation rule * adding more rules * Fixing checkstyle build and test errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @Builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](https://github.com/springdoc/springdoc-openapi-maven-plugin/compare/v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](https://github.com/dependabot/fetch-metadata/compare/v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](https://github.com/apache/maven-wrapper/compare/maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * BENCH-184 made removing item from basket transactional * BENCH-56: Bench 56 v2 (#81) * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * Bench 42 checkstyle3 (#8) * addig checkstyle * adding .env * adding .env * adding checkstyle rules * Fixing checkstyle errors * Fixing remaining checkstyle errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-79 item controller and service layer tests added. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * BENCH-79 code updated as per comments raised. * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes (#11) * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-57 WIP * BENCH-57 Added boilerplate tests for the order controller. * BENCH-80 Added 100% unit test coverage for order service and refactored order controller test. Also added setter method to ID field in Order entity model. * BENCH-80 Refactored OrderServiceTest.java as per comments. * BENCH-80 Refactored OrderServiceTest.java as per comments. * Delete CategoryControllerTest.java BENCH-81 Is doing tests relating to categories. * reverting the deleted changes * Delete OrderControllerTest.java Omitted, these tests were autogenerated via the DiffBlue tool and are outside the scope of BENCH-80. * reverting the deleted changes Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * checkstyle bug fix (#13) * BENCH-83 Changed application.yaml to disable open-in-view. * BENCH-46 Lombok Implemented and controller test updated to bypass security * Bench 42 checkstyle4 (#16) * adding some other checkstyle rules * adding identation rule * adding more rules * Fixing checkstyle build and test errors Co-authored-by: Oleksii <oleksi.rybak@gmail.com> * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @Builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](https://github.com/springdoc/springdoc-openapi-maven-plugin/compare/v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](https://github.com/dependabot/fetch-metadata/compare/v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](https://github.com/apache/maven-wrapper/compare/maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * BENCH-184 made removing item from basket transactional Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * (fix) update: Bump springdoc-openapi-ui from 1.6.12 to 1.6.13 (#84) Bumps [springdoc-openapi-ui](https://github.com/springdoc/springdoc-openapi) from 1.6.12 to 1.6.13. - [Release notes](https://github.com/springdoc/springdoc-openapi/releases) - [Changelog](https://github.com/springdoc/springdoc-openapi/blob/master/CHANGELOG.md) - [Commits](https://github.com/springdoc/springdoc-openapi/compare/v1.6.12...v1.6.13) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-ui dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * (fix) update: Bump springdoc-openapi-security from 1.6.12 to 1.6.13 (#83) Bumps [springdoc-openapi-security](https://github.com/springdoc/springdoc-openapi) from 1.6.12 to 1.6.13. - [Release notes](https://github.com/springdoc/springdoc-openapi/releases) - [Changelog](https://github.com/springdoc/springdoc-openapi/blob/master/CHANGELOG.md) - [Commits](https://github.com/springdoc/springdoc-openapi/compare/v1.6.12...v1.6.13) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-security dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * (fix) update: Bump PavanMudigonda/jacoco-reporter from 4.6 to 4.7 (#82) Bumps [PavanMudigonda/jacoco-reporter](https://github.com/PavanMudigonda/jacoco-reporter) from 4.6 to 4.7. - [Release notes](https://github.com/PavanMudigonda/jacoco-reporter/releases) - [Commits](https://github.com/PavanMudigonda/jacoco-reporter/compare/v4.6...v4.7) --- updated-dependencies: - dependency-name: PavanMudigonda/jacoco-reporter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bench-173: Aligining Category with API spec (#77) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * BENCH-36 (WIP) - Refactoring in progress * BENCH-81 added unit tests for Category * BENCH-81 adding verification to Category service tests * BENCH-81 checkstyle fixes * BENCH-81 fixing category tests * BENCH-81 updated category tests * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * BENCH-46 @Builder added to help with tests, also equal and hashcodes with ToString methods manually added to entities * BENCH-85: adding logging to different classes (#17) * BENCH-63 Added MapStruct dependency into the POM * BENCH-63 Added maven compiler plugin to add MapStruct support to POM * adding logging to different classes * BENCH-63 Added CategoryMapper interface. * BENCH-63 Added ItemMapper interface. * BENCH-63 Added OrderMapper interface * BENCH-63 Renamed AddOrderRequest.java to OrderRequest.java * BENCH-63 Integration of MapStruct into service layer. * BENCH-63 Added update order endpoint, fixed issue relating to get all orders * BENCH-63 Fixed bug relating to get all orders by adding the fetch type as EAGER, also initialised the status within the zero-argument constructor * BENCH-63 Added setters as these are required by the MapStruct library to map objects successfully * putting a proper annotation for class level * BENCH-63 Added unit test. * BENCH-63 Removed star import to comply with check style * standardizing API code * reverting test changes * BENCH-63 Fixed validation bug, reverted back to parameter-level validation * BENCH-63 Improved readability * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * BENCH-63 Improved readability * BENCH-63 Added unit test to test update order. * BENCH-63 Updated unit test. * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge conflicts * merge conflict * merge conflicts resolution * reverting test changes * enabling lombok with mapstruct * merge conflicts * reverting test changes * merge resolution * reverting test changes Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * BENCH-46 Conflicts resolved * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Updated README to link to Amazon Correto 17 * Bench 85 cleanup (#20) * cleanup and adding missing spring-security-test * pom revert * cleanup * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * Renamed request mappings to plural * Updated README to link to Amazon Correto 17 * BENCH-87 Updated Category and Item controller tests to reflect endpoint naming changes. * BENCH-86 order total price added * BENCH-46 add and remove item functions added to category. also items ignored on json in category request * BENCH-46 category equals updated to check name not id. * BENCH-86 Order total price included * BENCH-86 OrderItem total price updated * BENCH-86 imports optimized * BENCH-81: fixing rest endpoint issue (#23) * fixing rest endpoint issue * transaction update * fixing order adding issue (#24) * BENCH-NONE Added start-answerking.sh script for docker * fixing persistance loading issues (#25) * adding jacoco (#26) * BENCH-69: build workflow (#27) * build workflow * change workflow name * adding jacoco (#26) * adding cache to speed up build process * build workflow * change workflow name * adding cache to speed up build process * BENCH-58 Refactored package names, also changed package names from plural to singular as per BENCH-58 description. * BENCH-58 Fixed PR comment, renamed AnswerkingApplication to AnswerKingApplication and subsequent tests * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * BENCH-58-FIX Temporarily removed redundant test agreed with Oleksii, will integrate later when more purpose is added. * BENCH-58-FIX Removed OrderControllerIT.java as it was empty and served no purpose. Will re-write. * adding docker build pipeline (#31) * BENCH-108: Bench 108 push images (#32) * build docker images * change branch name * renaming branches * docker image workflow (#33) * adjusting repo name (#34) * BENCH-108: Bench 108 push images4 (#35) * adjusting repo name * docker compose push adjustment * permission change (#37) * BENCH-108: Bench 108 push images6 (#38) * permission change * permission delete * permission delete * change log in (#39) * BENCH-108: Bench 108 push images8 (#40) * change log in * adding another push * BENCH-108: Bench 108 push images9 (#41) * change log in * adding another push * syntax error * syntax error * adding repo name (#42) * push changes (#43) * docker push config (#45) * BENCH-125 refactored error responses to RFC-7807 format * BENCH-125 refactored handling for MethodArgumentNotValidException * BENCH-125 adding errors & traceId fields to RFC-7807 error responses * adjusting github repo name (#46) * repo name update (#47) * tag image (#48) * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-96 Static code analysis added * BENCH-96 Static code analysis property added * BENCH-96 java version specified * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * BENCH-161 Updated CategoryServiceTest * BENCH-161 Changes reflecting Andrews observations * BENCH-159: change to be compliant with the latest openapi version (#54) * change to be compliant with the latest openapi version * BENCH-161 Refactored codebase * BENCH-161 Fixed README.md * change to be compliant with the latest openapi version * BENCH-161 Updated CategoryServiceTest * rebase with main * add permission * BENCH-161 Changes reflecting Andrews observations * swagger config changes * change to be compliant with the latest openapi version * rebase with main * rebase conflict * add permission * swagger config changes Co-authored-by: martintaylor1635 <martintaylor1635@gmail.com> * adding api tags (#56) * BENCH-153 Updated SQL files to reflect new retired fields added in models. * BENCH-153 Created RetirementException to be thrown when dealing with retirements. * BENCH-153 Added retired field to category * BENCH-153 Updated CategoryController to reflect changes * BENCH-153 Added logic to CategoryService and ItemService * BENCH-153 Updated ItemController to reflect changes * BENCH-153 Updated unit tests in accordance with the new features * BENCH-161 Test * BENCH-161 Test * BENCH-153 Removed available field from Item, and reflected it thoughout * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Addressed PR comments from Andrew * BENCH-153 Updated RetirementException to reflect 404 not found rather than bad request * BENCH-153 Refactored RetirementException returning 410 GONE status * BENCH-153 Refactored Product model, added retired field to constructor * BENCH-153 Explicitly configured the ProductMapper to default the retired field to false when mapping a ProductRequest to a Product * BENCH-153 Addressed Andrews PR Comment: relocated constructor in Category model * BENCH-153 Addressed Andrews PR Comment: renamed local variable name within retireProduct in ProductService * BENCH-153 Addressed Andrews PR Comment: I would also suggest searching the codebase for any strings matching 'available' and see if there are any other ones we've missed * BENCH-153 Addressed Andrews PR Comment: Was this a mistake with the rebase? Seems a bit sparse * BENCH-56 v2 academy package removed. * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Dependabot Yaml Set Up * Automatically approve dependabot pull requests * Updated package-ecosystem to Maven * Bump springdoc-openapi-maven-plugin from 0.2 to 1.4 Bumps [springdoc-openapi-maven-plugin](https://github.com/springdoc/springdoc-openapi-maven-plugin) from 0.2 to 1.4. - [Release notes](https://github.com/springdoc/springdoc-openapi-maven-plugin/releases) - [Commits](https://github.com/springdoc/springdoc-openapi-maven-plugin/compare/v0.2...v1.4) --- updated-dependencies: - dependency-name: org.springdoc:springdoc-openapi-maven-plugin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Added github-actions ecosystem to dependabot.yml * Bump dependabot/fetch-metadata from 1.1.1 to 1.3.5 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.1.1 to 1.3.5. - [Release notes](https://github.com/dependabot/fetch-metadata/releases) - [Commits](https://github.com/dependabot/fetch-metadata/compare/v1.1.1...v1.3.5) --- updated-dependencies: - dependency-name: dependabot/fetch-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/cache from 1 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Bump maven-wrapper-plugin from 3.1.0 to 3.1.1 (#60) Bumps [maven-wrapper-plugin](https://github.com/apache/maven-wrapper) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-wrapper/releases) - [Commits](https://github.com/apache/maven-wrapper/compare/maven-wrapper-parent-3.1.0...maven-wrapper-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-wrapper-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BENCH-108-REFACTORING Refactored build_docker_package.yml as per requirements by Oleksii. * BENCH-108-REFACTORING Added the develop branc * BENCH-108-REFACTORING Added the master branch * BENCH-108-REFACTORING Added develop branch to the build_integration_and_code_analysis.yml workflow * Added github.actor check to dependabot workflow * sonar key update to project name. * github action checkout updated to v3 * Updated dependabot.yml pull request limit + prefix * BENCH-174 Added get category by ID endpoint * BENCH-172 Created NameUnavailableException and ProductAlreadyPresentException * BENCH-172 Updated services to reflect changes * BENCH-172 Updated tests to reflect changes * BENCH-148 Refactored SecurityConfig and added dependency for Snake YAML * BENCH-148 Fixed checkstyle complaints * BENCH-148 Added scope to POM dependency * Replaced primitive longs with Wrapper Class Longs * adding missing fields as per API spec * adding missing fields as per API spec * BENCH-179 Updated the MySQL dependency within the POM * BENCH-180 Refactored Spring Security Config and resolved warnings * BENCH-180 Addressed checkstyle warnings * test adjustments * test adjustments * small method optimization * small method optimization * adding missing fields as per API spec * adding missing fields as per API spec * test adjustments * test adjustments * small method optimization * small method optimization * BENCH-184 getting order 500 error fixed on all endpoints. * BENCH-162 Updated status codes for create product and category * BENCH-162 Reflected changes within tests * BENCH-185 Refactored Dockerfile, removed maintainer reference and switched to corretto image * BENCH-185 Created a batch script from Windows users to initialise Docker * BENCH-185 Updated bash script to initialise Docker * BENCH-185 Updated bash and batch script * BENCH-185 Updated bash script, changed operations order * BENCH-185 Overridden the banner for startup * adding more swagger docs (#80) * adding missing fields as per API spec * adding missing fields as per API spec * test adjustments * test adjustments * small method optimization * small method optimization * rebase with main * rebase with main * rebase with main * rebase with main * adding full stops * adding full stops * BENCH-184 made removing item from basket transactional * added missed final * adding missing fields as per API spec * test adjustments * small method optimization * rebase with main * rebase with main * rebase * rebase * rebase * rebase * rebase * adding full stops * added missed final * rebase * rebase * rebase with main * rebase with main * rebase * rebase * rebase * removing empty lines * rebase * rebase with main * rebase with main * rebase * rebase * added missed final * rebase * rebase with main * rebase with main * rebase * rebase * rebase Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: AudriusPutys <audrius.putys@answerdigital.com> Co-authored-by: Martin Taylor <martintaylor1635@gmail.com> Co-authored-by: MohammadIqbalAD <116073157+MohammadIqbalAD@users.noreply.github.com> Co-authored-by: AudriusPutys <116072957+AudriusPutys@users.noreply.github.com> Co-authored-by: Andy Flint <andrew.flint@answerdigital.com> Co-authored-by: AndyFlintAnswerDigital <116072207+AndyFlintAnswerDigital@users.noreply.github.com> Co-authored-by: MohammadIqbalAD <mohammad.iqbal@answerdigital.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.