feat: add breaking change section#1117
Conversation
|
Updating title with "!" to verify the label change |
|
Success. Changing back to feat: .... and adding "Breaking Change: ...." into the PR body |
|
Modifying the PR content |
8332ec0 to
53aea63
Compare
jorgepiloto
left a comment
There was a problem hiding this comment.
Why are we checking the body of the pull-reques? I thought we were checking only its title.
We could restrict this kind of checking to the title only. However, the current changes align with the conventional commit convention which also checks for breaking change footer. This is related to |
Adds checking for breaking change in the PR title and body. On repos following conventionnal commits, this will greatly help:
I think that this could be used as a metric to know whether a repo is ready to move to version
1.0.0.Extra change: reordering of the towncrier types to a (very) subjective priority list. Seems that the order in which the changes are displayed is following the
pyproject.toml/towncrier.tomlfile data.Close #722
Follow up of #810
Working tests performed:
The release only contains one of the PR (I forgot the other) and does not contain the reordering which was performed in this PR