Skip to content

ci: add missing permission in doc-deploy-dev#1128

Merged
jorgepiloto merged 2 commits intomainfrom
ci/add-missing-permission
Jan 27, 2026
Merged

ci: add missing permission in doc-deploy-dev#1128
jorgepiloto merged 2 commits intomainfrom
ci/add-missing-permission

Conversation

@SMoraisAnsys
Copy link
Copy Markdown
Contributor

Seems like the workflow on main has been failing since #1108 as a comment is now being added when the pull directory is cleaned (if it exists). Adding the pull-request: write permission should be enought to allow adding a comment through gh pr comment ...

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner January 26, 2026 14:17
@SMoraisAnsys SMoraisAnsys self-assigned this Jan 26, 2026
@github-actions github-actions Bot added the ci Pipelines maintenance related label Jan 26, 2026
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @SMoraisAnsys - zizmor improved a lot security but it also broke a lot of things...

@jorgepiloto jorgepiloto merged commit 35d8450 into main Jan 27, 2026
80 of 88 checks passed
@jorgepiloto jorgepiloto deleted the ci/add-missing-permission branch January 27, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pipelines maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants