refactor: switch doc-style and release-github actions to tomlkit from tomli#1234
Merged
refactor: switch doc-style and release-github actions to tomlkit from tomli#1234
doc-style and release-github actions to tomlkit from tomli#1234Conversation
moe-ad
requested review from
RobPasMue,
SMoraisAnsys,
ecoussoux-ansys,
germa89 and
jorgepiloto
RobPasMue
approved these changes
Mar 27, 2026
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
LGTM..
To be honest, moving forward, I would like to avoid allowing control over the version of tomlkit used. Forcing a specific version for this is more than acceptable since it is an internal dependency of our action - users shouldn't care about it.
Contributor
Author
|
Agreed. Maybe we can revise dependencies whose versions are controllable by users after wrapping up #991. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title states. Follow up to #1198 and #1223. This completes the switch from tomli to tomlkit across all actions.