Skip to content

chore: revert check-environment-approval action deprecation#1251

Merged
moe-ad merged 8 commits intomainfrom
chore/revert-pr-1232
Apr 10, 2026
Merged

chore: revert check-environment-approval action deprecation#1251
moe-ad merged 8 commits intomainfrom
chore/revert-pr-1232

Conversation

@moe-ad
Copy link
Copy Markdown
Contributor

@moe-ad moe-ad commented Apr 7, 2026

This reverts #1232. The dependabot behavior we observed is now gone.

@moe-ad moe-ad requested a review from a team as a code owner April 7, 2026 10:38
@github-actions github-actions Bot added ci Pipelines maintenance related docs Issues related to documentation labels Apr 7, 2026
Copy link
Copy Markdown
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoing on the discussion over the PR where the action was removed. Since the action wasn't used by any ansys repo and will probably not be, we should consider making it private. Could you update that ?

@moe-ad moe-ad force-pushed the chore/revert-pr-1232 branch from dec8ebe to 8222997 Compare April 8, 2026 08:07
@moe-ad
Copy link
Copy Markdown
Contributor Author

moe-ad commented Apr 8, 2026

Echoing on the discussion over the PR where the action was removed. Since the action wasn't used by any ansys repo and will probably not be, we should consider making it private. Could you update that ?

@SMoraisAnsys handled in 8222997.

Copy link
Copy Markdown
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In private action we enforce that all inputs should be passed and no default value should be used. Could you update that too ?

@moe-ad
Copy link
Copy Markdown
Contributor Author

moe-ad commented Apr 8, 2026

In private action we enforce that all inputs should be passed and no default value should be used. Could you update that too ?

Thanks for catching that @SMoraisAnsys. Done in b44c8e5.

Copy link
Copy Markdown
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add back the removed fragment file ?

Comment thread _check-environment-approval/action.yml Outdated
moe-ad and others added 3 commits April 9, 2026 10:49
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@moe-ad moe-ad requested a review from SMoraisAnsys April 9, 2026 08:53
@moe-ad moe-ad merged commit 36acae1 into main Apr 10, 2026
67 checks passed
@moe-ad moe-ad deleted the chore/revert-pr-1232 branch April 10, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pipelines maintenance related docs Issues related to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants