refactor(build-library)!: remove checkout opt-in option#1280
Conversation
|
If we are sure the input is not being used, we can just deprecate it silently and not have to wait for a major release. Waiting for a major release necessitates deprecating the inputs the usual way, i.e. not removing the inputs yet from the action itself and logging a warning about the expected deprecation if the input usage is detected. Then we remove completely just before a major release. If we agree on the first approach, we can just merge. I favor the first approach, I would like to avoid deprecation housekeeping if no-one has started using the input... 😄 |
|
I check on our orgs, here is the result for ansys https://github.com/search?q=org%3Aansys%20checkout-fetch-depth&type=code That's also how I found out that the options (previously requested) weren't used ... |
|
@MaxJPRey @RobPasMue Do you also agree with not waiting for a major release ? |
Agreed - let's release this asap |
Follow up of the discussion in #1269
The rationale behind these changes is that:
actions/checkoutto perform a custom checkout, the options under consideration have no use. In fact, that's how things are being handled in the link above...@moe-ad Depending on how we want to release those changes, we might have to wait for the next major release.