Skip to content

refactor(build-library)!: remove checkout opt-in option#1280

Merged
moe-ad merged 3 commits intomainfrom
refactor/remove-checkout-optin
Apr 24, 2026
Merged

refactor(build-library)!: remove checkout opt-in option#1280
moe-ad merged 3 commits intomainfrom
refactor/remove-checkout-optin

Conversation

@SMoraisAnsys
Copy link
Copy Markdown
Contributor

Follow up of the discussion in #1269

The rationale behind these changes is that:

  • these options haven't been used in our repos despite being public for multiple months. In fact, even the maintainer that was suggesting such changes doesn't seem to be using them, see this ref
  • since we allow one to disable actions/checkout to perform a custom checkout, the options under consideration have no use. In fact, that's how things are being handled in the link above...

@moe-ad Depending on how we want to release those changes, we might have to wait for the next major release.

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner April 22, 2026 12:58
@SMoraisAnsys SMoraisAnsys self-assigned this Apr 22, 2026
@SMoraisAnsys SMoraisAnsys added the breaking Changes that break backward compatibility label Apr 22, 2026
@moe-ad
Copy link
Copy Markdown
Contributor

moe-ad commented Apr 22, 2026

If we are sure the input is not being used, we can just deprecate it silently and not have to wait for a major release.

Waiting for a major release necessitates deprecating the inputs the usual way, i.e. not removing the inputs yet from the action itself and logging a warning about the expected deprecation if the input usage is detected. Then we remove completely just before a major release.

If we agree on the first approach, we can just merge. I favor the first approach, I would like to avoid deprecation housekeeping if no-one has started using the input... 😄

@SMoraisAnsys
Copy link
Copy Markdown
Contributor Author

I check on our orgs, here is the result for ansys https://github.com/search?q=org%3Aansys%20checkout-fetch-depth&type=code

That's also how I found out that the options (previously requested) weren't used ...

@SMoraisAnsys
Copy link
Copy Markdown
Contributor Author

@MaxJPRey @RobPasMue Do you also agree with not waiting for a major release ?

@RobPasMue
Copy link
Copy Markdown
Member

@MaxJPRey @RobPasMue Do you also agree with not waiting for a major release ?

Agreed - let's release this asap

@moe-ad moe-ad merged commit 0829a93 into main Apr 24, 2026
132 of 141 checks passed
@moe-ad moe-ad deleted the refactor/remove-checkout-optin branch April 24, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Changes that break backward compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants