Add ID to BasicInfo #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the 'id' string field to the BasicInfo message. Note that this change is backwards-incompatible because it changes the version associated with the 'version' field. This is acceptable because the API is still in early development, but can cause confusing errors when running with inconsistent .proto definitions between server and client.
Base automatically changed from
dgresch/enforce_version_on_modifying_requests
to
main
June 2, 2022 07:54
Merged
roosre
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the 'id' string field to the BasicInfo message. Note that
this change is backwards-incompatible because it changes the
version associated with the 'version' field. This is acceptable
because the API is still in early development, but can cause
confusing errors when running with inconsistent .proto definitions
between server and client.