Switch to 'src/' layout #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids issues where 'ansys-tools-protoc-helper' will find the .proto files which are located in the 'build' directory.
greschd
force-pushed
the
dgresch/src_layout
branch
from
335b270 to
7a9ece7
Compare
greschd
commented
Jun 3, 2022
| @@ -0,0 +1 @@ | |||
| 0.1.0.dev0 | |||
Member
Author
There was a problem hiding this comment.
Here, I just "normalized" the version; pip (or setuptools?) was already doing this when installing, but warning about the change.
Also moved the file, but the change is why git doesn't recognize the rename.
roosre
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PR on top of #2, to avoid merge conflicts.
When the
ansys/directory is at the top-level, the protoccompilation can run into problems if there is already a
build/directory containing.protofiles.This can be avoided by switching to a
src/layout.