- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1
 
Updating protos and adding V0 version #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            14 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      c63da46
              
                Adding latest update to V1
              
              
                RobPasMue 30ac90e
              
                Add V0 files (for good practice purpose)
              
              
                RobPasMue e22a464
              
                Import not being used
              
              
                RobPasMue ed32209
              
                Adapting V0 to work
              
              
                RobPasMue 6e1e274
              
                Adapting protolinter
              
              
                RobPasMue cc4e4ae
              
                Sorting imports in V1
              
              
                RobPasMue ce103b9
              
                Applying protolint to V0 files
              
              
                RobPasMue bd5bf1f
              
                Remove "vX" from package_info
              
              
                RobPasMue b10f19c
              
                Adapting for proper compilation
              
              
                RobPasMue d1eadfd
              
                Update ansys/api/discovery/v1/application.proto
              
              
                RobPasMue 949845d
              
                Update ansys/api/discovery/v0/scriptparameters.proto
              
              
                RobPasMue 6449a46
              
                Update ansys/api/discovery/v0/scriptparameters.proto
              
              
                RobPasMue 5fad48a
              
                Replace servicer with definition
              
              
                RobPasMue ac86672
              
                Change copyright year
              
              
                RobPasMue File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| 
          
            
          
           | 
    @@ -4,7 +4,6 @@ lint: | |
| # Linter directories to walk. | ||
| directories: | ||
| exclude: | ||
| - ansys | ||
| - codegen | ||
| - doc | ||
| - tests | ||
| 
          
            
          
           | 
    ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // Copyright (c) 2015, Google Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| 
     | 
||
| syntax = "proto3"; | ||
| 
     | 
||
| package google.api; | ||
| 
     | 
||
| import "ansys/api/discovery/google/api/http.proto"; | ||
| import "google/protobuf/descriptor.proto"; | ||
| 
     | 
||
| option go_package = "google.golang.org/genproto/googleapis/api/annotations;annotations"; | ||
| option java_multiple_files = true; | ||
| option java_outer_classname = "AnnotationsProto"; | ||
| option java_package = "com.google.api"; | ||
| option objc_class_prefix = "GAPI"; | ||
| 
     | 
||
| extend google.protobuf.MethodOptions { | ||
| // See `HttpRule`. | ||
| HttpRule http = 72295728; | ||
| } | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| // Copyright 2020 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| 
     | 
||
| syntax = "proto3"; | ||
| 
     | 
||
| package google.api; | ||
| 
     | 
||
| import "google/protobuf/descriptor.proto"; | ||
| 
     | 
||
| option go_package = "google.golang.org/genproto/googleapis/api/annotations;annotations"; | ||
| option java_multiple_files = true; | ||
| option java_outer_classname = "FieldBehaviorProto"; | ||
| option java_package = "com.google.api"; | ||
| option objc_class_prefix = "GAPI"; | ||
| 
     | 
||
| extend google.protobuf.FieldOptions { | ||
| // A designation of a specific field behavior (required, output only, etc.) | ||
| // in protobuf messages. | ||
| // | ||
| // Examples: | ||
| // | ||
| // string name = 1 [(google.api.field_behavior) = REQUIRED]; | ||
| // State state = 1 [(google.api.field_behavior) = OUTPUT_ONLY]; | ||
| // google.protobuf.Duration ttl = 1 | ||
| // [(google.api.field_behavior) = INPUT_ONLY]; | ||
| // google.protobuf.Timestamp expire_time = 1 | ||
| // [(google.api.field_behavior) = OUTPUT_ONLY, | ||
| // (google.api.field_behavior) = IMMUTABLE]; | ||
| repeated google.api.FieldBehavior field_behavior = 1052; | ||
| } | ||
| 
     | 
||
| // An indicator of the behavior of a given field (for example, that a field | ||
| // is required in requests, or given as output but ignored as input). | ||
| // This **does not** change the behavior in protocol buffers itself; it only | ||
| // denotes the behavior and may affect how API tooling handles the field. | ||
| // | ||
| // Note: This enum **may** receive new values in the future. | ||
| enum FieldBehavior { | ||
| // Conventional default for enums. Do not use this. | ||
| FIELD_BEHAVIOR_UNSPECIFIED = 0; | ||
| 
     | 
||
| // Specifically denotes a field as optional. | ||
| // While all fields in protocol buffers are optional, this may be specified | ||
| // for emphasis if appropriate. | ||
| OPTIONAL = 1; | ||
| 
     | 
||
| // Denotes a field as required. | ||
| // This indicates that the field **must** be provided as part of the request, | ||
| // and failure to do so will cause an error (usually `INVALID_ARGUMENT`). | ||
| REQUIRED = 2; | ||
| 
     | 
||
| // Denotes a field as output only. | ||
| // This indicates that the field is provided in responses, but including the | ||
| // field in a request does nothing (the server *must* ignore it and | ||
| // *must not* throw an error as a result of the field's presence). | ||
| OUTPUT_ONLY = 3; | ||
| 
     | 
||
| // Denotes a field as input only. | ||
| // This indicates that the field is provided in requests, and the | ||
| // corresponding field is not included in output. | ||
| INPUT_ONLY = 4; | ||
| 
     | 
||
| // Denotes a field as immutable. | ||
| // This indicates that the field may be set once in a request to create a | ||
| // resource, but may not be changed thereafter. | ||
| IMMUTABLE = 5; | ||
| } | 
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need all those options.
For an other projects, we were not using them. Just checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably leave them for now. Just in case they need them. But I will ask the Discovery team. This may take some time to clarify.